Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Side by Side Diff: chromeos/dbus/fake_bluetooth_profile_service_provider.h

Issue 1124883004: Submission for C++ Readability (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address first round of review comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROMEOS_DBUS_FAKE_BLUETOOTH_PROFILE_SERVICE_PROVIDER_H_ 5 #ifndef CHROMEOS_DBUS_FAKE_BLUETOOTH_PROFILE_SERVICE_PROVIDER_H_
6 #define CHROMEOS_DBUS_FAKE_BLUETOOTH_PROFILE_SERVICE_PROVIDER_H_ 6 #define CHROMEOS_DBUS_FAKE_BLUETOOTH_PROFILE_SERVICE_PROVIDER_H_
7 7
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
11 #include "chromeos/chromeos_export.h" 11 #include "chromeos/chromeos_export.h"
12 #include "chromeos/dbus/bluetooth_profile_service_provider.h" 12 #include "chromeos/dbus/bluetooth_profile_service_provider.h"
13 #include "dbus/file_descriptor.h" 13 #include "dbus/file_descriptor.h"
14 #include "dbus/object_path.h" 14 #include "dbus/object_path.h"
15 15
16 namespace chromeos { 16 namespace chromeos {
17 17
18 // FakeBluetoothProfileServiceProvider simulates the behavior of a local 18 // FakeBluetoothProfileServiceProvider simulates the behavior of a local
19 // Bluetooth agent object and is used both in test cases in place of a 19 // Bluetooth agent object and is used both in test cases in place of a
20 // mock and on the Linux desktop. 20 // mock and on the Linux desktop.
21 //
22 // This class is only called from the dbus origin thread and is not thread-safe.
21 class CHROMEOS_EXPORT FakeBluetoothProfileServiceProvider 23 class CHROMEOS_EXPORT FakeBluetoothProfileServiceProvider
22 : public BluetoothProfileServiceProvider { 24 : public BluetoothProfileServiceProvider {
23 public: 25 public:
24 FakeBluetoothProfileServiceProvider(const dbus::ObjectPath& object_path, 26 FakeBluetoothProfileServiceProvider(const dbus::ObjectPath& object_path,
25 Delegate *delegate); 27 Delegate* delegate);
26 ~FakeBluetoothProfileServiceProvider() override; 28 ~FakeBluetoothProfileServiceProvider() override;
27 29
28 // Each of these calls the equivalent 30 // Each of these calls the equivalent
29 // BluetoothProfileServiceProvider::Delegate method on the object passed on 31 // BluetoothProfileServiceProvider::Delegate method on the object passed on
30 // construction. 32 // construction.
31 virtual void Release(); 33 void Released();
32 virtual void NewConnection( 34 void NewConnection(const dbus::ObjectPath& device_path,
33 const dbus::ObjectPath& device_path, 35 scoped_ptr<dbus::FileDescriptor> fd,
34 scoped_ptr<dbus::FileDescriptor> fd, 36 const Delegate::Options& options,
35 const Delegate::Options& options, 37 const Delegate::ConfirmationCallback& callback);
36 const Delegate::ConfirmationCallback& callback); 38 void RequestDisconnection(const dbus::ObjectPath& device_path,
37 virtual void RequestDisconnection( 39 const Delegate::ConfirmationCallback& callback);
38 const dbus::ObjectPath& device_path, 40 void Cancel();
39 const Delegate::ConfirmationCallback& callback);
40 virtual void Cancel();
41 41
42 const dbus::ObjectPath& object_path() { return object_path_; } 42 const dbus::ObjectPath& object_path() const { return object_path_; }
43 43
44 private: 44 private:
45 friend class FakeBluetoothProfileManagerClient; 45 friend class FakeBluetoothProfileManagerClient;
46 46
47 // D-Bus object path we are faking. 47 // D-Bus object path we are faking.
48 dbus::ObjectPath object_path_; 48 dbus::ObjectPath object_path_;
49 49
50 // All incoming method calls are passed on to the Delegate and a callback 50 // All incoming method calls are passed on to the Delegate and a callback
51 // passed to generate the reply. |delegate_| is generally the object that 51 // passed to generate the reply. |delegate_| is generally the object that
52 // owns this one, and must outlive it. 52 // owns this one, and must outlive it.
53 Delegate* delegate_; 53 Delegate* delegate_;
54
55 DISALLOW_COPY_AND_ASSIGN(FakeBluetoothProfileServiceProvider);
54 }; 56 };
55 57
56 } // namespace chromeos 58 } // namespace chromeos
57 59
58 #endif // CHROMEOS_DBUS_FAKE_BLUETOOTH_PROFILE_SERVICE_PROVIDER_H_ 60 #endif // CHROMEOS_DBUS_FAKE_BLUETOOTH_PROFILE_SERVICE_PROVIDER_H_
61
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698