Submission for C++ Readability

Submission for C++ Readability

Some files have had minor comments changes made, others just an added newline at the end for git to allow adding.

BUG=None

Committed: https://crrev.com/512c2f57f0dbcb312ee5aa79451568f7a8233a02
Cr-Commit-Position: refs/heads/master@{#336270}

[Marie Janssen, 2015-05-20 17:28:49]

jamuraa@chromium.org changed reviewers:
+ omoikane@google.com

[omoikane, 2015-05-22 23:55:28]

First round of review comments.

https://codereview.chromium.org/1124883004/diff/1/chromeos/dbus/fake_bluetoot...
File chromeos/dbus/fake_bluetooth_profile_manager_client.cc (right):

https://codereview.chromium.org/1124883004/diff/1/chromeos/dbus/fake_bluetoot...
chromeos/dbus/fake_bluetooth_profile_manager_client.cc:7: 
Only 1 blank line needed here.

https://codereview.chromium.org/1124883004/diff/1/chromeos/dbus/fake_bluetoot...
chromeos/dbus/fake_bluetooth_profile_manager_client.cc:46: "Can't register this
UUID"));
Current format makes the comma that separates the two arguments to PostTask less
visible, try something like this instead:

    base::MessageLoop::current()->PostTask(
        FROM_HERE,
        base::Bind(error_callback,
                   bluetooth_profile_manager::kErrorInvalidArguments,
                   "Can't register this UUID"));

https://codereview.chromium.org/1124883004/diff/1/chromeos/dbus/fake_bluetoot...
chromeos/dbus/fake_bluetooth_profile_manager_client.cc:50: // check options for
channel & psm
Is this a TODO comment?  If so, consider formatting it as such:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#TODO_Comments

The lines below don't seem to be related to "channel" and "psm".

https://codereview.chromium.org/1124883004/diff/1/chromeos/dbus/fake_bluetoot...
chromeos/dbus/fake_bluetooth_profile_manager_client.cc:109: return NULL;
nullptr is preferred over NULL, since nullptr provides a bit more type safety.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#0_and_nullptr...

(4 more files like this)

https://codereview.chromium.org/1124883004/diff/1/chromeos/dbus/fake_bluetoot...
File chromeos/dbus/fake_bluetooth_profile_service_provider.h (right):

https://codereview.chromium.org/1124883004/diff/1/chromeos/dbus/fake_bluetoot...
chromeos/dbus/fake_bluetooth_profile_service_provider.h:20: // mock and on the
Linux desktop.
Please also include some comments to document thread safety expectations for
this class.

(please do this for all files)

https://codereview.chromium.org/1124883004/diff/1/chromeos/dbus/fake_bluetoot...
chromeos/dbus/fake_bluetooth_profile_service_provider.h:25: Delegate *delegate);
This pointer has the space before '*', while the pointer at line  53 has it
before.  Please pick one format and be consistent.

https://codereview.chromium.org/1124883004/diff/1/chromeos/dbus/fake_bluetoot...
chromeos/dbus/fake_bluetooth_profile_service_provider.h:31: virtual void
Release();
"override" is preferred over "virtual" for inherited functions.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Inheritance

https://codereview.chromium.org/1124883004/diff/1/chromeos/dbus/fake_bluetoot...
chromeos/dbus/fake_bluetooth_profile_service_provider.h:42: const
dbus::ObjectPath& object_path() { return object_path_; }
This function does not modify class members, and should be declared const.

https://codereview.chromium.org/1124883004/diff/1/chromeos/dbus/fake_bluetoot...
chromeos/dbus/fake_bluetooth_profile_service_provider.h:45: friend class
FakeBluetoothProfileManagerClient;
Friends are usually declared last in the class, since knowing which other
mock/test code has access is somewhat an implementation detail.  Because most
people read code from top to bottom, it's preferable to move other declarations
near the top before all friend declarations.

(2 more files like this)

https://codereview.chromium.org/1124883004/diff/1/chromeos/dbus/fake_bluetoot...
chromeos/dbus/fake_bluetooth_profile_service_provider.h:54: };
Copy constructors should be disabled.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Copyable_Mova...

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_adapter_chromeos.cc (right):

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_adapter_chromeos.cc:64: // static
These "// static" comments are often a maintenance burden and do not add much
value, and should be deleted.

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_adapter_chromeos.cc:70: }
End of namespace here should have "// namespace device" comments.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Namespace_For...

Comments are not required for short namespaces, but it seems inconsistent that
it's present for the relatively short namespace ending at line 60 and not here.

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_adapter_chromeos.cc:365:
PoweredChanged(properties->powered.value());
These conditional blocks should be enclosed in braces.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Conditionals

(please fix everywhere)

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_adapter_chromeos.cc:431:
NotifyDeviceChanged(device_chromeos);
Body of this conditional should be enclosed in braces because the conditional
expression already spanned multiple lines.

(please fix everywhere)

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_adapter_chromeos.cc:815: && num_discovery_sessions_ >
0) {
"&&" usually appears at the end of the previous line instead of the beginning of
the line.  Even among files in this changelist, this is the only place that has
&& at the beginning of the line.

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_adapter_chromeos.cc:1133: current_filter_.reset();
This conditional block should be enclosed in braces.

Note that cpplint will catch stuff like this.  cpplint is less accurate for
chromium code, but it still emits useful warnings, and should be used as a first
order check.

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_adapter_chromeos.h (right):

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_adapter_chromeos.h:60: public
chromeos::BluetoothAgentServiceProvider::Delegate {
Multiple inheritance is generally not allowed.  When they are allowed, the base
classes are usually pure interfaces and are named with Interface suffix.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Multiple_Inhe...

This might not be something that you can fix in this readability review so I
won't hold up this review for this change, but perhaps you can raise the issue
with your team to see if they can rename the base classes accordingly.

(2 more files like this)

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_adapter_chromeos.h:113: // its D-Bus properties.
All function parameters should be documented with comments.  In particular, for
pointer parameters like "device" here, be sure to say who owns the pointer and
whether they can be NULL.

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_adapter_chromeos.h:150:
BluetoothProfileServiceProvider::Delegate* delegate,
"delegate" looks like an output parameter because it's not const, and output
parameter are generally declared last in the function parameter list.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Function_Para...

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_adapter_profile_chromeos_unittest.cc (right):

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_adapter_profile_chromeos_unittest.cc:194: };
This trailing semicolon is redundant and should be deleted.

(4 more places like this in this file, 1 more file like this)

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_chromeos_unittest.cc (right):

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_chromeos_unittest.cc:142: private:
These lines should be shifted 1 space left.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Class_Format

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_chromeos_unittest.cc:1653: auto nullInstance =
scoped_ptr<BluetoothDiscoveryFilter>();
This variable should be renamed to follow naming convention for local variables.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Variable_Names

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_chromeos_unittest.cc:2576: for(int i = 1; i <= 7;
++i) {
Need extra space after "for".

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_device_chromeos.h (right):

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_device_chromeos.h:95: // BluetoothDevice override
This line should be shifted 1 space left.

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_socket_chromeos.cc (right):

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_socket_chromeos.cc:184: UnregisterProfile();
This line should be shifted 1 space right.

[Marie Janssen, 2015-06-18 21:08:36]

Hi Don,

Sorry this took so long to round-trip. PTAL.

Marie

https://codereview.chromium.org/1124883004/diff/1/chromeos/dbus/fake_bluetoot...
File chromeos/dbus/fake_bluetooth_profile_manager_client.cc (right):

https://codereview.chromium.org/1124883004/diff/1/chromeos/dbus/fake_bluetoot...
chromeos/dbus/fake_bluetooth_profile_manager_client.cc:7: 
On 2015/05/22 23:55:26, omoikane wrote:
> Only 1 blank line needed here.

Done.

https://codereview.chromium.org/1124883004/diff/1/chromeos/dbus/fake_bluetoot...
chromeos/dbus/fake_bluetooth_profile_manager_client.cc:46: "Can't register this
UUID"));
On 2015/05/22 23:55:26, omoikane wrote:
> Current format makes the comma that separates the two arguments to PostTask
less
> visible, try something like this instead:
> 
>     base::MessageLoop::current()->PostTask(
>         FROM_HERE,
>         base::Bind(error_callback,
>                    bluetooth_profile_manager::kErrorInvalidArguments,
>                    "Can't register this UUID"));

Done.

https://codereview.chromium.org/1124883004/diff/1/chromeos/dbus/fake_bluetoot...
chromeos/dbus/fake_bluetooth_profile_manager_client.cc:50: // check options for
channel & psm
On 2015/05/22 23:55:26, omoikane wrote:
> Is this a TODO comment?  If so, consider formatting it as such:
> http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#TODO_Comments
> 
> The lines below don't seem to be related to "channel" and "psm".

Done.

https://codereview.chromium.org/1124883004/diff/1/chromeos/dbus/fake_bluetoot...
chromeos/dbus/fake_bluetooth_profile_manager_client.cc:109: return NULL;
On 2015/05/22 23:55:26, omoikane wrote:
> nullptr is preferred over NULL, since nullptr provides a bit more type safety.
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#0_and_nullptr...
> 
> (4 more files like this)

Done.

https://codereview.chromium.org/1124883004/diff/1/chromeos/dbus/fake_bluetoot...
File chromeos/dbus/fake_bluetooth_profile_service_provider.h (right):

https://codereview.chromium.org/1124883004/diff/1/chromeos/dbus/fake_bluetoot...
chromeos/dbus/fake_bluetooth_profile_service_provider.h:20: // mock and on the
Linux desktop.
On 2015/05/22 23:55:27, omoikane wrote:
> Please also include some comments to document thread safety expectations for
> this class.
> 
> (please do this for all files)

In general, classes in the device tree in Chromium do not worry about
thread-safety - they are only called from the UI thread.  I've added comments to
clarify this.

https://codereview.chromium.org/1124883004/diff/1/chromeos/dbus/fake_bluetoot...
chromeos/dbus/fake_bluetooth_profile_service_provider.h:25: Delegate *delegate);
On 2015/05/22 23:55:27, omoikane wrote:
> This pointer has the space before '*', while the pointer at line  53 has it
> before.  Please pick one format and be consistent.

Done.

https://codereview.chromium.org/1124883004/diff/1/chromeos/dbus/fake_bluetoot...
chromeos/dbus/fake_bluetooth_profile_service_provider.h:31: virtual void
Release();
On 2015/05/22 23:55:27, omoikane wrote:
> "override" is preferred over "virtual" for inherited functions.
> http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Inheritance

Done.

https://codereview.chromium.org/1124883004/diff/1/chromeos/dbus/fake_bluetoot...
chromeos/dbus/fake_bluetooth_profile_service_provider.h:42: const
dbus::ObjectPath& object_path() { return object_path_; }
On 2015/05/22 23:55:27, omoikane wrote:
> This function does not modify class members, and should be declared const.

Done.

https://codereview.chromium.org/1124883004/diff/1/chromeos/dbus/fake_bluetoot...
chromeos/dbus/fake_bluetooth_profile_service_provider.h:45: friend class
FakeBluetoothProfileManagerClient;
On 2015/05/22 23:55:27, omoikane wrote:
> Friends are usually declared last in the class, since knowing which other
> mock/test code has access is somewhat an implementation detail.  Because most
> people read code from top to bottom, it's preferable to move other
declarations
> near the top before all friend declarations.
> 
> (2 more files like this)

In Chromium code friends at the beginning is more common, see
nfc_device_client.h, shill_third_party_vpn_client.h, shill_profile_client.h,
etc.

https://codereview.chromium.org/1124883004/diff/1/chromeos/dbus/fake_bluetoot...
chromeos/dbus/fake_bluetooth_profile_service_provider.h:54: };
On 2015/05/22 23:55:27, omoikane wrote:
> Copy constructors should be disabled.
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Copyable_Mova...

Done.

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_adapter_chromeos.cc (right):

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_adapter_chromeos.cc:64: // static
On 2015/05/22 23:55:27, omoikane wrote:
> These "// static" comments are often a maintenance burden and do not add much
> value, and should be deleted.

This "// static" is convention in Chromium code.

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_adapter_chromeos.cc:70: }
On 2015/05/22 23:55:27, omoikane wrote:
> End of namespace here should have "// namespace device" comments.
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Namespace_For...
> 
> Comments are not required for short namespaces, but it seems inconsistent that
> it's present for the relatively short namespace ending at line 60 and not
here.

Done.

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_adapter_chromeos.cc:365:
PoweredChanged(properties->powered.value());
On 2015/05/22 23:55:27, omoikane wrote:
> These conditional blocks should be enclosed in braces.
> http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Conditionals
> 
> (please fix everywhere)

Done.

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_adapter_chromeos.cc:431:
NotifyDeviceChanged(device_chromeos);
On 2015/05/22 23:55:27, omoikane wrote:
> Body of this conditional should be enclosed in braces because the conditional
> expression already spanned multiple lines.
> 
> (please fix everywhere)

Done.

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_adapter_chromeos.cc:815: && num_discovery_sessions_ >
0) {
On 2015/05/22 23:55:27, omoikane wrote:
> "&&" usually appears at the end of the previous line instead of the beginning
of
> the line.  Even among files in this changelist, this is the only place that
has
> && at the beginning of the line.

Done.

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_adapter_chromeos.cc:1133: current_filter_.reset();
On 2015/05/22 23:55:27, omoikane wrote:
> This conditional block should be enclosed in braces.
> 
> Note that cpplint will catch stuff like this.  cpplint is less accurate for
> chromium code, but it still emits useful warnings, and should be used as a
first
> order check.

Done.

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_adapter_chromeos.h (right):

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_adapter_chromeos.h:113: // its D-Bus properties.
On 2015/05/22 23:55:27, omoikane wrote:
> All function parameters should be documented with comments.  In particular,
for
> pointer parameters like "device" here, be sure to say who owns the pointer and
> whether they can be NULL.

Done.

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_adapter_chromeos.h:150:
BluetoothProfileServiceProvider::Delegate* delegate,
On 2015/05/22 23:55:27, omoikane wrote:
> "delegate" looks like an output parameter because it's not const, and output
> parameter are generally declared last in the function parameter list.
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Function_Para...

|delegate| is not an output parameter - it's an input, and cannot be const
because incoming connection ownership is passed from the
BluetoothAdapterProfileChromeOS (which acts as a
BluetoothProfileServiceProvider::Delegate) to the specific Delegate passed here.
 This is explained in the function description.

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_chromeos_unittest.cc (right):

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_chromeos_unittest.cc:142: private:
On 2015/05/22 23:55:28, omoikane wrote:
> These lines should be shifted 1 space left.
> http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Class_Format

Done.

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_chromeos_unittest.cc:1653: auto nullInstance =
scoped_ptr<BluetoothDiscoveryFilter>();
On 2015/05/22 23:55:28, omoikane wrote:
> This variable should be renamed to follow naming convention for local
variables.
> http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Variable_Names

Done.

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_chromeos_unittest.cc:2576: for(int i = 1; i <= 7;
++i) {
On 2015/05/22 23:55:28, omoikane wrote:
> Need extra space after "for".

Done.

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_device_chromeos.h (right):

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_device_chromeos.h:95: // BluetoothDevice override
On 2015/05/22 23:55:28, omoikane wrote:
> This line should be shifted 1 space left.

Done.

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_socket_chromeos.cc (right):

https://codereview.chromium.org/1124883004/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_socket_chromeos.cc:184: UnregisterProfile();
On 2015/05/22 23:55:28, omoikane wrote:
> This line should be shifted 1 space right.

Done.

[omoikane, 2015-06-23 01:23:40]

lgtm

Minor comments regarding blank lines, but mostly these files are in good shape. 
Please get one of your teammates to review and approve this change so that you
can submit it.  Readability will be granted after change is submitted.

https://codereview.chromium.org/1124883004/diff/20001/chromeos/dbus/fake_blue...
File chromeos/dbus/fake_bluetooth_profile_manager_client.cc (right):

https://codereview.chromium.org/1124883004/diff/20001/chromeos/dbus/fake_blue...
chromeos/dbus/fake_bluetooth_profile_manager_client.cc:113: 
This trailing blank line is redundant and should be deleted.

(8 more files like this)

https://codereview.chromium.org/1124883004/diff/20001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_adapter_profile_chromeos.h (right):

https://codereview.chromium.org/1124883004/diff/20001/device/bluetooth/blueto...
device/bluetooth/bluetooth_adapter_profile_chromeos.h:109: #endif
Need end comments for header guard.
#endif  // DEVICE_BLUETOOTH_BLUETOOTH_ADAPTER_PROFILE_CHROMEOS_H_

[Marie Janssen, 2015-06-23 17:37:53]

jamuraa@chromium.org changed reviewers:
+ armansito@chromium.org, keybuk@chromium.org

[armansito, 2015-06-24 21:37:10]

lgtm with nits

https://codereview.chromium.org/1124883004/diff/40001/chromeos/dbus/fake_blue...
File chromeos/dbus/fake_bluetooth_profile_service_provider.h (right):

https://codereview.chromium.org/1124883004/diff/40001/chromeos/dbus/fake_blue...
chromeos/dbus/fake_bluetooth_profile_service_provider.h:33: void Released();
Add override keyword to all of these.

https://codereview.chromium.org/1124883004/diff/40001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_adapter_chromeos.h (right):

https://codereview.chromium.org/1124883004/diff/40001/device/bluetooth/blueto...
device/bluetooth/bluetooth_adapter_chromeos.h:119: // its D-Bus properties. 
|device| is owned by the caller and cannot be NULL.
nit: Remove extra space before "|device|" in second sentence.

[Marie Janssen, 2015-06-24 22:43:40]

The CQ bit was checked by jamuraa@chromium.org

[Marie Janssen, 2015-06-24 22:43:40]

The patchset sent to the CQ was uploaded after l-g-t-m from omoikane@google.com,
armansito@chromium.org
Link to the patchset: https://codereview.chromium.org/1124883004/#ps60001
(title: "address nits")

[commit-bot: I haz the power, 2015-06-24 22:46:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1124883004/60001

[commit-bot: I haz the power, 2015-06-24 22:51:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-24 22:51:59]

Exceeded global retry quota

[Marie Janssen, 2015-06-25 18:13:06]

The CQ bit was checked by jamuraa@chromium.org

[Marie Janssen, 2015-06-25 18:13:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
armansito@chromium.org, omoikane@google.com
Link to the patchset: https://codereview.chromium.org/1124883004/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2015-06-25 18:13:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1124883004/100001

[commit-bot: I haz the power, 2015-06-25 18:46:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-25 18:46:24]

Exceeded global retry quota

[Marie Janssen, 2015-06-25 21:23:19]

https://codereview.chromium.org/1124883004/diff/40001/chromeos/dbus/fake_blue...
File chromeos/dbus/fake_bluetooth_profile_service_provider.h (right):

https://codereview.chromium.org/1124883004/diff/40001/chromeos/dbus/fake_blue...
chromeos/dbus/fake_bluetooth_profile_service_provider.h:33: void Released();
On 2015/06/24 21:37:10, armansito wrote:
> Add override keyword to all of these.

These actually aren't overriding anything.  They call the functions on the
|delegate| passed to the constructor, but this class is not a
BluetoothProfileServiceProvider::Delegate.

[Marie Janssen, 2015-06-25 21:26:17]

The CQ bit was checked by jamuraa@chromium.org

[Marie Janssen, 2015-06-25 21:26:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
armansito@chromium.org, omoikane@google.com
Link to the patchset: https://codereview.chromium.org/1124883004/#ps120001
(title: "revert overrides")

[commit-bot: I haz the power, 2015-06-25 21:27:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1124883004/120001

[commit-bot: I haz the power, 2015-06-25 21:55:50]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-06-25 21:56:53]

Patchset 7 (id:??) landed as
https://crrev.com/512c2f57f0dbcb312ee5aa79451568f7a8233a02
Cr-Commit-Position: refs/heads/master@{#336270}