Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1124863004: MIPS: Improve '[es6] When comparing two symbols we may need to throw a TypeError'. (Closed)

Created:
5 years, 7 months ago by balazs.kilvady
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Improve '[es6] When comparing two symbols we may need to throw a TypeError'. Improve d26f5d392317dcf1eef3693eadfa1b95a8850df8 Original commit message: When comparing a symbol to istself using <, <=, > or >= we need to throw a TypeError. This is correctly handled in the runtime function so if we are comparing a symbol fall back to use the runtime. BUG= Committed: https://crrev.com/2a86d26f33a60cf42e407f8eb07139fd02d81f20 Cr-Commit-Position: refs/heads/master@{#28240}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M src/mips/code-stubs-mips.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
balazs.kilvady
5 years, 7 months ago (2015-05-05 16:22:19 UTC) #2
paul.l...
lgtm
5 years, 7 months ago (2015-05-05 16:29:32 UTC) #4
arv (Not doing code reviews)
LGTM Thanks
5 years, 7 months ago (2015-05-05 16:35:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124863004/1
5 years, 7 months ago (2015-05-05 16:36:20 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 18:50:58 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 18:51:16 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a86d26f33a60cf42e407f8eb07139fd02d81f20
Cr-Commit-Position: refs/heads/master@{#28240}

Powered by Google App Engine
This is Rietveld 408576698