LayoutTests/editing/style/apply-style-crash3.html - Issue 1124863003: Harden changing font style over unknown elements.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/style/apply-style-crash3.html

Issue 1124863003: Harden changing font style over unknown elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="../../resources/js-test.js"></script>

	5 </head>

	6 <body>

	7 <unknown>

	8 <script>

	9

	10 if (window.testRunner) {

	11 testRunner.dumpAsText();

	12 testRunner.waitUntilDone();

	13 }

	14

	15 window.jsTestIsAsync = true;

	16

	17 function onDOMNodeRemoved(e) {

	18 try {

	19 e.srcElement.insertAdjacentHTML('afterbegin', ' ');

	20 document.execCommand('FontSizeDelta', false, '1px');

	21 } catch(e) {}
	leviw_travelin_and_unemployed 2015/05/05 18:21:40 Is this try/catch necessary? Is this try/catch necessary? sof 2015/05/05 19:47:32 An alternative is to add an Element type check, wh Show quoted text On 2015/05/05 18:21:40, leviw wrote: > Is this try/catch necessary? An alternative is to add an Element type check, which I've now done.
	22 }

	23 document.addEventListener("DOMNodeRemoved", onDOMNodeRemoved, false);

	24

	25 function runTest() {

	26 document.designMode = document.designMode == "on" ? "off" : "on";

	27 document.execCommand("SelectAll", false)

	28 var unknown = document.getElementsByTagName("unknown")[0];

	29 unknown.textContent = "sss";

	30 unknown.outerHTML = "";

	31 document.execCommand("SelectAll", false);

	32 // Put description() here so as to not upset test condition.

	33 description("Verify that changing the style over an unknown element does not crash.");

	34 finishJSTest();

	35 }

	36

	37 window.onload = runTest;
	leviw_travelin_and_unemployed 2015/05/05 18:21:40 If you move this script tag to the end, you probab If you move this script tag to the end, you probably don't need the onload handler. sof 2015/05/05 19:47:32 Moved stuff around a bit to avoid having to trigge Show quoted text On 2015/05/05 18:21:40, leviw wrote: > If you move this script tag to the end, you probably don't need the onload > handler. Moved stuff around a bit to avoid having to trigger it via onload.
	38 </script>

	39 <textarea>

	40 </body>
	leviw_travelin_and_unemployed 2015/05/05 18:21:40 Nit: </body> and </html> aren't necessary. Nit: </body> and </html> aren't necessary. sof 2015/05/05 19:47:32 Just following local convention :) Show quoted text On 2015/05/05 18:21:40, leviw wrote: > Nit: </body> and </html> aren't necessary. Just following local convention :)
	41 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/editing/style/apply-style-crash3-expected.txt » ('j') | no next file with comments »