cc/input/top_controls_manager.cc - Issue 1124843002: [Cleanup] Remove duplicated check from TopControlsManager::ScrollBy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/input/top_controls_manager.cc

Issue 1124843002: [Cleanup] Remove duplicated check from TopControlsManager::ScrollBy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/input/top_controls_manager.cc

diff --git a/cc/input/top_controls_manager.cc b/cc/input/top_controls_manager.cc

index 56c9d8f43ff8d14419cb93986ebce052f278fda2..b5915c9ead0f2a10f5153a7d6b9db21cd7a3a7c1 100644

--- a/cc/input/top_controls_manager.cc

+++ b/cc/input/top_controls_manager.cc

@@ -107,8 +107,8 @@ gfx::Vector2dF TopControlsManager::ScrollBy(

if (pinch_gesture_active_)

return pending_delta;

- if (!TopControlsHeight())

- return pending_delta;

+// if (!TopControlsHeight())

+// return pending_delta;

bokan 2015/05/05 11:16:54 Don't comment out code, just remove it.

if (permitted_state_ == SHOWN && pending_delta.y() > 0)

return pending_delta;

« no previous file with comments | « no previous file | no next file » | no next file with comments »