[Cleanup] Remove duplicated check from TopControlsManager::ScrollBy

[Cleanup] Remove duplicated check from TopControlsManager::ScrollBy

Check for top bar control height is getting unneccessarily duplicated in
TopControlsManager::ScrollBy. The duplicated code seems to have got
added in the merging of the below two patches:
https://crrev.com/982333003 and https://crrev.com/961023002

BUG=None

R=bokan,aelias

TESTS=Not Required

Committed: https://crrev.com/4c0a51aeb774512d9f2560e84dfd2be0a0687018
Cr-Commit-Position: refs/heads/master@{#329138}

[r.kasibhatla, 2015-05-05 06:13:27]

r.kasibhatla@samsung.com changed reviewers:
+ aelias@chromium.org

[r.kasibhatla, 2015-05-05 06:14:49]

PTAL. 
Minor change to remove unnecessary duplicated top bar height check at the top of
TopControlsManager::ScrollBy.

[bokan, 2015-05-05 11:16:54]

https://codereview.chromium.org/1124843002/diff/1/cc/input/top_controls_manag...
File cc/input/top_controls_manager.cc (right):

https://codereview.chromium.org/1124843002/diff/1/cc/input/top_controls_manag...
cc/input/top_controls_manager.cc:111: //    return pending_delta;
Don't comment out code, just remove it.

[r.kasibhatla, 2015-05-06 04:06:05]

On 2015/05/05 at 11:16:54, bokan wrote:
>
https://codereview.chromium.org/1124843002/diff/1/cc/input/top_controls_manag...
> File cc/input/top_controls_manager.cc (right):
> 
>
https://codereview.chromium.org/1124843002/diff/1/cc/input/top_controls_manag...
> cc/input/top_controls_manager.cc:111: //    return pending_delta;
> Don't comment out code, just remove it.

Ugh. I was assuming that I deleted the code instead of commenting. How silly of
me :D.

[bokan, 2015-05-08 03:40:18]

On 2015/05/06 04:06:05, r.kasibhatla wrote:
> On 2015/05/05 at 11:16:54, bokan wrote:
> >
>
https://codereview.chromium.org/1124843002/diff/1/cc/input/top_controls_manag...
> > File cc/input/top_controls_manager.cc (right):
> > 
> >
>
https://codereview.chromium.org/1124843002/diff/1/cc/input/top_controls_manag...
> > cc/input/top_controls_manager.cc:111: //    return pending_delta;
> > Don't comment out code, just remove it.
> 
> Ugh. I was assuming that I deleted the code instead of commenting. How silly
of
> me :D.

Non owner lgtm, thanks for the cleanup

[RaviKasibhatla, 2015-05-08 19:04:21]

On 2015/05/08 at 03:40:18, bokan wrote:
> On 2015/05/06 04:06:05, r.kasibhatla wrote:
> > On 2015/05/05 at 11:16:54, bokan wrote:
> > >
> >
https://codereview.chromium.org/1124843002/diff/1/cc/input/top_controls_manag...
> > > File cc/input/top_controls_manager.cc (right):
> > > 
> > >
> >
https://codereview.chromium.org/1124843002/diff/1/cc/input/top_controls_manag...
> > > cc/input/top_controls_manager.cc:111: //    return pending_delta;
> > > Don't comment out code, just remove it.
> > 
> > Ugh. I was assuming that I deleted the code instead of commenting. How silly
of
> > me :D.
> 
> Non owner lgtm, thanks for the cleanup

aelias: Gentle ping! Can you please stamp the change?

[aelias_OOO_until_Jul13, 2015-05-08 22:45:01]

The CQ bit was checked by aelias@chromium.org

[aelias_OOO_until_Jul13, 2015-05-08 22:45:02]

lgtm

[commit-bot: I haz the power, 2015-05-08 22:46:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1124843002/20001

[commit-bot: I haz the power, 2015-05-09 03:03:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-09 03:04:00]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  cast_shell_android on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  cast_shell_linux on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[r.kasibhatla, 2015-05-11 03:48:15]

The CQ bit was checked by r.kasibhatla@samsung.com

[commit-bot: I haz the power, 2015-05-11 03:50:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1124843002/20001

[commit-bot: I haz the power, 2015-05-11 10:52:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-11 10:54:06]

Patchset 2 (id:??) landed as
https://crrev.com/4c0a51aeb774512d9f2560e84dfd2be0a0687018
Cr-Commit-Position: refs/heads/master@{#329138}