Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 1124813003: [chrome/browser/chromeos/drive] Avoid use of MessageLoopProxy by use of TTRH (Closed)

Created:
5 years, 7 months ago by Pranay
Modified:
5 years, 7 months ago
Reviewers:
xiyuan, satorux1, hashimoto
CC:
chromium-reviews, hashimoto+watch_chromium.org, tzik, tfarina, nhiroki, oshima+watch_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org, anujsharma, satorux1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in chrome/browser/chromeos/drive module. MessageLoopProxy is deprecated. This basically does a search and replace of: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). MessageLoopProxy -> SingleThreadTaskRunner BUG=391045 Committed: https://crrev.com/229290b50b2c5425371015d9526a71d0e33df4aa Cr-Commit-Position: refs/heads/master@{#329807}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed unit test errors #

Patch Set 3 : Fixed nits #

Total comments: 2

Patch Set 4 : Fixed Review Comments 2 : Indent #

Total comments: 2

Patch Set 5 : Fixed Review Comments 3 : Indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -103 lines) Patch
M chrome/browser/chromeos/drive/change_list_loader.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/change_list_loader_unittest.cc View 1 2 3 3 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/drive/change_list_processor_unittest.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/directory_loader_unittest.cc View 1 2 3 4 2 chunks +11 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/drive/file_cache_unittest.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/truncate_operation.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_unittest.cc View 1 2 3 6 chunks +14 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system_util_unittest.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/fileapi/async_file_util.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/fileapi/fileapi_worker.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler.cc View 1 2 3 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/job_scheduler_unittest.cc View 1 2 3 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/remove_stale_cache_files_unittest.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata_storage_unittest.cc View 1 10 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata_unittest.cc View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/search_metadata_unittest.cc View 1 15 chunks +18 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/drive/sync_client.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/sync_client_unittest.cc View 1 2 3 6 chunks +16 lines, -13 lines 0 comments Download

Messages

Total messages: 26 (8 generated)
Pranay
PTAL Thanks
5 years, 7 months ago (2015-05-05 08:56:14 UTC) #2
xiyuan
+satorux owner of c/b/chromeos/drive lgtm since the change is a mostly mechanical.
5 years, 7 months ago (2015-05-05 16:15:19 UTC) #3
satorux1
https://codereview.chromium.org/1124813003/diff/1/chrome/browser/chromeos/drive/change_list_loader_unittest.cc File chrome/browser/chromeos/drive/change_list_loader_unittest.cc (right): https://codereview.chromium.org/1124813003/diff/1/chrome/browser/chromeos/drive/change_list_loader_unittest.cc#newcode104 chrome/browser/chromeos/drive/change_list_loader_unittest.cc:104: loader_controller_.get())); Please keep them aligned vertically for consistency (ex. ...
5 years, 7 months ago (2015-05-05 16:23:23 UTC) #5
Pranay
Hi Satorux, Thanks for the review. Also apologies, all unittest files has other dependencies w.r.t. ...
5 years, 7 months ago (2015-05-07 12:19:17 UTC) #6
Pranay
https://codereview.chromium.org/1124813003/diff/1/chrome/browser/chromeos/drive/change_list_loader_unittest.cc File chrome/browser/chromeos/drive/change_list_loader_unittest.cc (right): https://codereview.chromium.org/1124813003/diff/1/chrome/browser/chromeos/drive/change_list_loader_unittest.cc#newcode104 chrome/browser/chromeos/drive/change_list_loader_unittest.cc:104: loader_controller_.get())); On 2015/05/05 16:23:23, satorux1 wrote: > Please keep ...
5 years, 7 months ago (2015-05-08 10:21:17 UTC) #7
Pranay
Hi, updated the patch as per build issues & alignment consistencies :) PTAL Thanks
5 years, 7 months ago (2015-05-08 10:23:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124813003/40001
5 years, 7 months ago (2015-05-08 10:52:58 UTC) #11
Pranay
PING :)
5 years, 7 months ago (2015-05-12 13:49:39 UTC) #13
satorux1
I will defer to fukino@ and hashimoto@ PING :) https://codereview.chromium.org/1124813003/ To unsubscribe from this group ...
5 years, 7 months ago (2015-05-12 14:06:35 UTC) #14
hashimoto
https://codereview.chromium.org/1124813003/diff/40001/chrome/browser/chromeos/drive/change_list_loader_unittest.cc File chrome/browser/chromeos/drive/change_list_loader_unittest.cc (right): https://codereview.chromium.org/1124813003/diff/40001/chrome/browser/chromeos/drive/change_list_loader_unittest.cc#newcode84 chrome/browser/chromeos/drive/change_list_loader_unittest.cc:84: pref_service_.get(), This indent looks weird. Did you run "git ...
5 years, 7 months ago (2015-05-13 05:47:11 UTC) #16
Pranay
PTAL https://codereview.chromium.org/1124813003/diff/40001/chrome/browser/chromeos/drive/change_list_loader_unittest.cc File chrome/browser/chromeos/drive/change_list_loader_unittest.cc (right): https://codereview.chromium.org/1124813003/diff/40001/chrome/browser/chromeos/drive/change_list_loader_unittest.cc#newcode84 chrome/browser/chromeos/drive/change_list_loader_unittest.cc:84: pref_service_.get(), Sure..Done here and in other files, also ...
5 years, 7 months ago (2015-05-13 06:51:34 UTC) #17
hashimoto
https://codereview.chromium.org/1124813003/diff/60001/chrome/browser/chromeos/drive/directory_loader_unittest.cc File chrome/browser/chromeos/drive/directory_loader_unittest.cc (right): https://codereview.chromium.org/1124813003/diff/60001/chrome/browser/chromeos/drive/directory_loader_unittest.cc#newcode81 chrome/browser/chromeos/drive/directory_loader_unittest.cc:81: pref_service_.get(), This looks still weird. How did you run ...
5 years, 7 months ago (2015-05-13 15:38:14 UTC) #18
Pranay
Done https://codereview.chromium.org/1124813003/diff/60001/chrome/browser/chromeos/drive/directory_loader_unittest.cc File chrome/browser/chromeos/drive/directory_loader_unittest.cc (right): https://codereview.chromium.org/1124813003/diff/60001/chrome/browser/chromeos/drive/directory_loader_unittest.cc#newcode81 chrome/browser/chromeos/drive/directory_loader_unittest.cc:81: pref_service_.get(), Since git cl format was interfering with ...
5 years, 7 months ago (2015-05-14 04:42:00 UTC) #19
Pranay
PTAL again :) Thanks
5 years, 7 months ago (2015-05-14 04:42:32 UTC) #20
hashimoto
lgtm
5 years, 7 months ago (2015-05-14 04:44:17 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124813003/80001
5 years, 7 months ago (2015-05-14 04:47:18 UTC) #24
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 7 months ago (2015-05-14 05:21:11 UTC) #25
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 05:22:33 UTC) #26
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/229290b50b2c5425371015d9526a71d0e33df4aa
Cr-Commit-Position: refs/heads/master@{#329807}

Powered by Google App Engine
This is Rietveld 408576698