Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: google_apis/gcm/engine/mcs_client.h

Issue 1124783002: [GCM] Wiring heartbeat interval calls to GCMDriver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@store-heartbeat-gcm
Patch Set: Rebasing Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: google_apis/gcm/engine/mcs_client.h
diff --git a/google_apis/gcm/engine/mcs_client.h b/google_apis/gcm/engine/mcs_client.h
index a81bcbe95bb9c4cd843d861940749297c088fea6..0ddf5ddb3f986b30dec8f38a44aabb656990c175 100644
--- a/google_apis/gcm/engine/mcs_client.h
+++ b/google_apis/gcm/engine/mcs_client.h
@@ -160,8 +160,8 @@ class GCM_EXPORT MCSClient {
void AddHeartbeatInterval(const std::string& scope, int interval_ms);
void RemoveHeartbeatInterval(const std::string& scope);
- HeartbeatManager& GetHeartbeatManagerForTesting() {
- return heartbeat_manager_;
+ HeartbeatManager* GetHeartbeatManagerForTesting() {
+ return &heartbeat_manager_;
}
private:
@@ -226,7 +226,7 @@ class GCM_EXPORT MCSClient {
MCSPacketInternal PopMessageForSend();
// Gets the minimum interval from the map of scopes to intervals.
- int GetMinCustomHeartbeatInterval();
+ int GetMinHeartbeatInterval();
Nicolas Zea 2015/05/13 17:57:37 nit: maybe call this GetHeartbeatIntervalMs (and m
fgorski 2015/05/13 18:59:16 Done.
// Local version string. Sent on login.
const std::string version_string_;

Powered by Google App Engine
This is Rietveld 408576698