components/gcm_driver/gcm_client.h - Issue 1124783002: [GCM] Wiring heartbeat interval calls to GCMDriver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/gcm_client.h

Issue 1124783002: [GCM] Wiring heartbeat interval calls to GCMDriver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@store-heartbeat-gcm

Patch Set: Adding MCS client tests for storing heartbeat interval Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/gcm_driver/gcm_client.h

diff --git a/components/gcm_driver/gcm_client.h b/components/gcm_driver/gcm_client.h

index 2aa224a369aba8f176cc012b4444998dcbe393a0..3c6092bc6d72b86015a0acf094a299b2be75565b 100644

--- a/components/gcm_driver/gcm_client.h

+++ b/components/gcm_driver/gcm_client.h

@@ -309,6 +309,11 @@ class GCMClient {

// Updates the timer used by the HeartbeatManager for sending heartbeats.

virtual void UpdateHeartbeatTimer(scoped_ptr<base::Timer> timer) = 0;

+ // Gets and sets custom heartbeat interval for the MCS connection.

Nicolas Zea 2015/05/07 18:13:52 Describe what scope corresponds to?

fgorski 2015/05/10 06:44:33 Done.

+ virtual void AddHeartbeatInterval(const std::string& scope,

+ int interval_ms) = 0;

+ virtual void RemoveHeartbeatInterval(const std::string& scope) = 0;

};

} // namespace gcm

« no previous file with comments | « components/gcm_driver/fake_gcm_driver.cc ('k') | components/gcm_driver/gcm_client_impl.h » ('j') | components/gcm_driver/gcm_client_impl.cc » ('J')