Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: base/OWNERS

Issue 1124763003: Update from https://crrev.com/327068 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: update nacl, buildtools, fix display_change_notifier_unittest Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/BUILD.gn ('k') | base/android/base_jni_registrar.cc » ('j') | mojo/public/tools/BUILD.gn » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 mark@chromium.org 1 mark@chromium.org
2 darin@chromium.org 2 darin@chromium.org
3 ajwong@chromium.org
4 thakis@chromium.org 3 thakis@chromium.org
5 danakj@chromium.org 4 danakj@chromium.org
6 rvargas@chromium.org 5 rvargas@chromium.org
7 thestig@chromium.org 6 thestig@chromium.org
8 7
9 # On extended leave. 8 # On extended leave.
10 willchan@chromium.org 9 willchan@chromium.org
11 10
12 # Chromium is a very mature project, most things that are generally useful are 11 # Chromium is a very mature project, most things that are generally useful are
13 # already here, and that things not here aren't generally useful. 12 # already here, and that things not here aren't generally useful.
14 # 13 #
15 # Base is pulled into many projects. For example, various ChromeOS daemons. So 14 # Base is pulled into many projects. For example, various ChromeOS daemons. So
16 # the bar for adding stuff is that it must have demonstrated wide 15 # the bar for adding stuff is that it must have demonstrated wide
17 # applicability. Prefer to add things closer to where they're used (i.e. "not 16 # applicability. Prefer to add things closer to where they're used (i.e. "not
18 # base"), and pull into base only when needed. In a project our size, 17 # base"), and pull into base only when needed. In a project our size,
19 # sometimes even duplication is OK and inevitable. 18 # sometimes even duplication is OK and inevitable.
20 # 19 #
21 # Adding a new logging macro DPVELOG_NE is not more clear than just 20 # Adding a new logging macro DPVELOG_NE is not more clear than just
22 # writing the stuff you want to log in a regular logging statement, even 21 # writing the stuff you want to log in a regular logging statement, even
23 # if it makes your calling code longer. Just add it to your own code. 22 # if it makes your calling code longer. Just add it to your own code.
24 23
25 per-file *.isolate=csharp@chromium.org 24 per-file *.isolate=csharp@chromium.org
26 per-file *.isolate=maruel@chromium.org 25 per-file *.isolate=maruel@chromium.org
27 per-file security_unittest.cc=jln@chromium.org 26 per-file security_unittest.cc=jln@chromium.org
28 27
29 # For Android-specific changes: 28 # For Android-specific changes:
30 per-file *android*=nyquist@chromium.org 29 per-file *android*=nyquist@chromium.org
31 per-file *android*=rmcilroy@chromium.org 30 per-file *android*=rmcilroy@chromium.org
32 per-file *android*=yfriedman@chromium.org 31 per-file *android*=yfriedman@chromium.org
OLDNEW
« no previous file with comments | « base/BUILD.gn ('k') | base/android/base_jni_registrar.cc » ('j') | mojo/public/tools/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698