Issue 112473002: Don't crash if a failed dependency is in the root package.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 112473002: Don't crash if a failed dependency is in the root package. (Closed)

Created:
7 years ago by Bob Nystrom

Modified:
7 years ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't crash if a failed dependency is in the root package. BUG=https://code.google.com/p/dart/issues/detail?id=15550 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=31071

Patch Set 2 : Revise. #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -8 lines)			Patch
	M	sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart	View	1	1 chunk	+12 lines, -8 lines	0 comments	Download
	M	sdk/lib/_internal/pub/test/version_solver_test.dart	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm https://codereview.chromium.org/112473002/diff/1/sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart File sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart (right): https://codereview.chromium.org/112473002/diff/1/sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart#newcode302 sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart:302: addDependencies(String name, Iterable<PackageDep> deps) { I'm not a ...

7 years ago (2013-12-11 06:55:18 UTC) #2

Bob Nystrom

Committed patchset #2 manually as r31071 (presubmit successful).

7 years ago (2013-12-11 17:35:24 UTC) #3

Bob Nystrom

7 years ago (2013-12-11 17:35:37 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/112473002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart (right):

https://codereview.chromium.org/112473002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart:302:
addDependencies(String name, Iterable<PackageDep> deps) {
On 2013/12/11 06:55:18, nweiz wrote:
> I'm not a big fan of type-annotating parameters to local functions, since we
> don't type-annotate anything else that's strictly local.

Done. Not sure what I was thinking.

Expand Messages | Collapse Messages

Issue 112473002: Don't crash if a failed dependency is in the root package. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Revise. #

Messages