pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart - Issue 1124613002: Revert "dart2js: add type arguments to constructor in case the class needs rti."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart

Issue 1124613002: Revert "dart2js: add type arguments to constructor in case the class needs rti." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/class_stub_generator.dart ('k') | pkg/compiler/lib/src/js_emitter/type_test_registry.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart

diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart

index 1a7537e41e462bb12a907fc45a67677437953608..58ad5bd8f634c6c66846aec8214d90cb4ade494b 100644

--- a/pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart

+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart

@@ -235,15 +235,10 @@ function $setupProgramName(programData, typesOffset) {

str += parameter;

body += ("this." + field + " = " + parameter + ";\\n");

}

- // TODO(zarah): Check whether there is any gain in always having this

- // property and if so, add it unconditionally.

- body += "if (typeInfo) this.\$builtinTypeInfo = typeInfo;\\n";

if (supportsDirectProtoAccess) {

body += "this." + #deferredActionString + "();";

}

- if (fields.length > 0) str += ",";

- str += "typeInfo) {\\n" + body + "}\\n";

+ str += ") {\\n" + body + "}\\n";

str += name + ".$typeNameProperty=\\"" + name + "\\";\\n";

str += "\$desc=\$collectedClasses." + name + "[1];\\n";

str += name + ".prototype = \$desc;\\n";