runtime/vm/intrinsifier_mips.cc - Issue 1124553006: Fix Bigint_rsh on mips (was obviously not properly tested).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intrinsifier_mips.cc

Issue 1124553006: Fix Bigint_rsh on mips (was obviously not properly tested). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intrinsifier_mips.cc

===================================================================

--- runtime/vm/intrinsifier_mips.cc (revision 45521)

+++ runtime/vm/intrinsifier_mips.cc (working copy)

@@ -868,9 +868,12 @@

// T2 = 32 - T3

__ subu(T2, ZR, T3);

__ addiu(T2, T2, Immediate(32));

+ // T1 = x_digits[n ~/ _DIGIT_BITS] >> (n % _DIGIT_BITS)

+ __ lw(T1, Address(V0, 0));

+ __ addiu(V0, V0, Immediate(Bigint::kBytesPerDigit));

Label loop_exit;

__ beq(V1, T6, &loop_exit);

- __ delay_slot()->mov(T1, ZR);

+ __ delay_slot()->srlv(T1, T1, T3);

Label loop;

__ Bind(&loop);

__ lw(T0, Address(V0, 0));

« no previous file with comments | « no previous file | no next file » | no next file with comments »