Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1124553002: Remove now unused OrderedSocketData. (Closed)

Created:
5 years, 7 months ago by Ryan Hamilton
Modified:
5 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove now unused OrderedSocketData. BUG=332112 Committed: https://crrev.com/a025cb6753e0a34624baa3fb426aede1225b97ac Cr-Commit-Position: refs/heads/master@{#330292}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -153 lines) Patch
M net/socket/socket_test_util.h View 1 2 chunks +1 line, -56 lines 0 comments Download
M net/socket/socket_test_util.cc View 1 chunk +0 lines, -97 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Ryan Hamilton
5 years, 7 months ago (2015-05-03 14:48:13 UTC) #2
ramant (doing other things)
lgtm https://codereview.chromium.org/1124553002/diff/1/net/socket/socket_test_util.h File net/socket/socket_test_util.h (right): https://codereview.chromium.org/1124553002/diff/1/net/socket/socket_test_util.h#newcode169 net/socket/socket_test_util.h:169: // For data providers tha only allows reads ...
5 years, 7 months ago (2015-05-04 01:09:56 UTC) #3
Ryan Hamilton
Thanks https://codereview.chromium.org/1124553002/diff/1/net/socket/socket_test_util.h File net/socket/socket_test_util.h (right): https://codereview.chromium.org/1124553002/diff/1/net/socket/socket_test_util.h#newcode169 net/socket/socket_test_util.h:169: // For data providers tha only allows reads ...
5 years, 7 months ago (2015-05-05 00:27:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124553002/20001
5 years, 7 months ago (2015-05-05 00:29:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124553002/20001
5 years, 7 months ago (2015-05-16 18:13:43 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-16 19:17:07 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:32:07 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a025cb6753e0a34624baa3fb426aede1225b97ac
Cr-Commit-Position: refs/heads/master@{#330292}

Powered by Google App Engine
This is Rietveld 408576698