Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1124533002: Add CompleteRead to SequencedSocketData and convert all but 3 tests (Closed)

Created:
5 years, 7 months ago by Ryan Hamilton
Modified:
5 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add CompleteRead to SequencedSocketData and convert all but 3 tests to use SequencedSocketData. Reduces runtime to 7 seconds from 11 seconds on my linux workstation BUG=332112 Committed: https://crrev.com/d7b1887392866667126162a4e7854a2736449970 Cr-Commit-Position: refs/heads/master@{#328221} Committed: https://crrev.com/323208450b20d7612021318738da087964e487d4 Cr-Commit-Position: refs/heads/master@{#330288}

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -90 lines) Patch
M net/http/http_network_transaction_unittest.cc View 1 2 4 chunks +18 lines, -10 lines 0 comments Download
M net/socket/sequenced_socket_data_unittest.cc View 1 2 3 chunks +27 lines, -0 lines 0 comments Download
M net/socket/socket_test_util.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M net/socket/socket_test_util.cc View 1 2 6 chunks +36 lines, -11 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 1 2 14 chunks +56 lines, -69 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Ryan Hamilton
5 years, 7 months ago (2015-05-03 14:17:35 UTC) #2
ramant (doing other things)
lgtm
5 years, 7 months ago (2015-05-04 01:08:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124533002/20001
5 years, 7 months ago (2015-05-04 21:12:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124533002/20001
5 years, 7 months ago (2015-05-04 23:51:18 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-04 23:56:07 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d7b1887392866667126162a4e7854a2736449970 Cr-Commit-Position: refs/heads/master@{#328221}
5 years, 7 months ago (2015-05-04 23:56:55 UTC) #10
Dan Beam
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1129473002/ by dbeam@chromium.org. ...
5 years, 7 months ago (2015-05-05 01:55:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124533002/60001
5 years, 7 months ago (2015-05-16 15:54:51 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 7 months ago (2015-05-16 15:57:18 UTC) #16
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:31:56 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/323208450b20d7612021318738da087964e487d4
Cr-Commit-Position: refs/heads/master@{#330288}

Powered by Google App Engine
This is Rietveld 408576698