Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 112453002: Remove dependency on skia from remoting (Closed)

Created:
7 years ago by Sergey Ulanov
Modified:
7 years ago
Reviewers:
Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Remove dependency on skia from remoting Remoting uses types in webrtc/modules/desktop_capture to represent rectangles, vectors and regions. This CL removes a few places left where we were still using Skia types and removes Skia from DEPS. Also removed leftover InvalidateRegion() declaration from desktop_session_proxy.h . R=jamiewalch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240925

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -99 lines) Patch
M remoting/host/DEPS View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/host/chromoting_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/client_session.h View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/client_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/client_session_control.h View 2 chunks +5 lines, -2 lines 0 comments Download
M remoting/host/client_session_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M remoting/host/desktop_resizer.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/desktop_resizer_win.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/desktop_session_agent.h View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/desktop_session_agent.cc View 2 chunks +3 lines, -1 line 0 comments Download
M remoting/host/desktop_session_proxy.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M remoting/host/host_mock_objects.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/host_status_observer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/host/host_window_proxy.cc View 1 3 chunks +5 lines, -2 lines 0 comments Download
M remoting/host/input_injector_linux.cc View 1 5 chunks +9 lines, -9 lines 0 comments Download
M remoting/host/input_injector_mac.cc View 1 2 3 4 chunks +8 lines, -11 lines 0 comments Download
M remoting/host/input_injector_win.cc View 2 chunks +7 lines, -10 lines 0 comments Download
M remoting/host/ipc_desktop_environment_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/local_input_monitor_linux.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/local_input_monitor_mac.mm View 1 2 3 7 chunks +9 lines, -7 lines 0 comments Download
M remoting/host/local_input_monitor_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/local_input_monitor_win.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/remote_input_filter.h View 3 chunks +2 lines, -3 lines 0 comments Download
M remoting/host/remote_input_filter.cc View 1 3 chunks +10 lines, -7 lines 0 comments Download
M remoting/host/remote_input_filter_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M remoting/host/video_scheduler.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/win/rdp_client.h View 1 2 3 4 5 6 7 8 2 chunks +6 lines, -3 lines 0 comments Download
M remoting/host/win/rdp_client.cc View 1 2 3 4 5 6 7 4 chunks +5 lines, -3 lines 0 comments Download
M remoting/host/win/rdp_client_unittest.cc View 1 2 3 4 5 6 7 2 chunks +5 lines, -3 lines 0 comments Download
M remoting/host/win/rdp_client_window.h View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/win/rdp_client_window.cc View 1 2 3 4 5 6 7 2 chunks +1 line, -2 lines 0 comments Download
M remoting/host/win/rdp_desktop_session.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -1 line 0 comments Download
M remoting/remoting.gyp View 1 2 3 4 5 6 7 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Sergey Ulanov
7 years ago (2013-12-11 04:33:38 UTC) #1
Jamie
lgtm, assuming my comments don't raise further concerns. https://codereview.chromium.org/112453002/diff/20001/remoting/host/DEPS File remoting/host/DEPS (left): https://codereview.chromium.org/112453002/diff/20001/remoting/host/DEPS#oldcode11 remoting/host/DEPS:11: "+third_party/webrtc", ...
7 years ago (2013-12-11 18:15:26 UTC) #2
Sergey Ulanov
https://codereview.chromium.org/112453002/diff/20001/remoting/host/DEPS File remoting/host/DEPS (left): https://codereview.chromium.org/112453002/diff/20001/remoting/host/DEPS#oldcode11 remoting/host/DEPS:11: "+third_party/webrtc", On 2013/12/11 18:15:27, Jamie wrote: > It's not ...
7 years ago (2013-12-11 19:40:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/112453002/40001
7 years ago (2013-12-11 19:40:12 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=200423
7 years ago (2013-12-11 19:57:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/112453002/60001
7 years ago (2013-12-12 07:51:05 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) check_deps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=202461
7 years ago (2013-12-12 08:22:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/112453002/100001
7 years ago (2013-12-12 18:39:12 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=61385
7 years ago (2013-12-12 20:58:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/112453002/120001
7 years ago (2013-12-12 21:08:02 UTC) #10
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=134037
7 years ago (2013-12-12 23:24:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/112453002/180001
7 years ago (2013-12-14 22:47:41 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=204281
7 years ago (2013-12-14 23:16:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/112453002/180001
7 years ago (2013-12-16 09:36:18 UTC) #14
Sergey Ulanov
7 years ago (2013-12-16 18:03:09 UTC) #15
Message was sent while issue was closed. 
Committed patchset #9 manually as r240925 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698