Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1124433006: Allow page range selection in system dialog called from preview (Closed)

Created:
5 years, 7 months ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow page range selection in system dialog called from preview Two location for this option could case small confusion. Still some users may prefer to select pages in system dialog. BUG=461843 Committed: https://crrev.com/95fa3c9594c34b3009d521bb3347af9b67d4d314 Cr-Commit-Position: refs/heads/master@{#328260}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -15 lines) Patch
M printing/printing_context.h View 1 chunk +2 lines, -1 line 0 comments Download
M printing/printing_context.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M printing/printing_context_android.h View 1 chunk +2 lines, -1 line 0 comments Download
M printing/printing_context_android.cc View 1 chunk +2 lines, -1 line 0 comments Download
M printing/printing_context_linux.h View 1 chunk +2 lines, -1 line 0 comments Download
M printing/printing_context_linux.cc View 1 chunk +2 lines, -1 line 0 comments Download
M printing/printing_context_mac.h View 1 chunk +2 lines, -1 line 0 comments Download
M printing/printing_context_mac.mm View 1 chunk +2 lines, -1 line 0 comments Download
M printing/printing_context_no_system_dialog.h View 1 chunk +2 lines, -1 line 0 comments Download
M printing/printing_context_no_system_dialog.cc View 1 chunk +2 lines, -1 line 0 comments Download
M printing/printing_context_win.h View 1 chunk +2 lines, -1 line 0 comments Download
M printing/printing_context_win.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Vitaly Buka (NO REVIEWS)
5 years, 7 months ago (2015-05-04 22:07:29 UTC) #2
Aleksey Shlyapnikov
lgtm
5 years, 7 months ago (2015-05-04 23:15:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124433006/1
5 years, 7 months ago (2015-05-05 02:35:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 03:03:40 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 03:04:35 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/95fa3c9594c34b3009d521bb3347af9b67d4d314
Cr-Commit-Position: refs/heads/master@{#328260}

Powered by Google App Engine
This is Rietveld 408576698