Better error from pdfium_test when page too big to render.

fpdfsdk/src/fpdfview.cpp

Index: fpdfsdk/src/fpdfview.cpp
diff --git a/fpdfsdk/src/fpdfview.cpp b/fpdfsdk/src/fpdfview.cpp
index 3207ebe336000ca0afd373fb31af1e5b83e0c872..606bb291d680c6ba8d374bd1935935ec429a2bfb 100644
--- a/fpdfsdk/src/fpdfview.cpp
+++ b/fpdfsdk/src/fpdfview.cpp
@@ -12,6 +12,7 @@
 #include "../include/fpdf_ext.h"
 #include "../../../core/src/fxcrt/fx_safe_types.h"
 #include "../../third_party/base/numerics/safe_conversions_impl.h"
+#include "../../third_party/base/nonstd_unique_ptr.h"

[Lei Zhang, 2015/05/08 18:05:15]

nit: alphabetical order.

[Tom Sepez, 2015/05/08 18:13:01]

Done.

 
 CPDF_CustomAccess::CPDF_CustomAccess(FPDF_FILEACCESS* pFileAccess)
 {
@@ -597,9 +598,11 @@ DLLEXPORT void STDCALL FPDF_PageToDevice(FPDF_PAGE page, int start_x, int start_
 
 DLLEXPORT FPDF_BITMAP STDCALL FPDFBitmap_Create(int width, int height, int alpha)
 {
-	CFX_DIBitmap* pBitmap = new CFX_DIBitmap;
-	pBitmap->Create(width, height, alpha ? FXDIB_Argb : FXDIB_Rgb32);
-	return pBitmap;
+	nonstd::unique_ptr<CFX_DIBitmap> pBitmap(new CFX_DIBitmap);

[Lei Zhang, 2015/05/08 18:05:15]

nit: Can we get rid of tabs in this entire function?

[Tom Sepez, 2015/05/08 18:13:01]

Yes.  The only thing worse than tabs in files are people who think its okay to
have tabs in files (because you'll spend the rest of your life futily arguing
with them rather than doing work).

+	if (!pBitmap->Create(width, height, alpha ? FXDIB_Argb : FXDIB_Rgb32)) {
+		return NULL;
+	}
+	return pBitmap.release();
 }
 
 DLLEXPORT FPDF_BITMAP STDCALL FPDFBitmap_CreateEx(int width, int height, int format, void* first_scan, int stride)