src/bootstrapper.cc - Issue 1124403006: Reland "Prevent stack overflow in the serializer/deserializer."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/bootstrapper.cc

Issue 1124403006: Reland "Prevent stack overflow in the serializer/deserializer." (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix msan issue Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/bootstrapper.cc

diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc

index b1b18f8a0611a1cf7c5cafc318f6c6601b5d8da4..f2e51960fd962f849f114b31314e82d60873ceaf 100644

--- a/src/bootstrapper.cc

+++ b/src/bootstrapper.cc

@@ -2831,6 +2831,7 @@ void Genesis::TransferNamedProperties(Handle<JSObject> from,

if (value->IsPropertyCell()) {

value = handle(PropertyCell::cast(*value)->value(), isolate());

}

+ if (value->IsTheHole()) continue;

PropertyDetails details = properties->DetailsAt(i);

DCHECK_EQ(kData, details.kind());

JSObject::AddProperty(to, key, value, details.attributes());

« no previous file with comments | « src/api.cc ('k') | src/objects.cc » ('j') | no next file with comments »