Source/modules/cachestorage/Cache.h - Issue 1124403005: CacheStorage: Implement Cache.addAll() behind a flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/cachestorage/Cache.h

Issue 1124403005: CacheStorage: Implement Cache.addAll() behind a flag (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/cachestorage/script-tests/cache-add.js ('K') | « LayoutTests/http/tests/cachestorage/worker/cache-add-expected.txt ('k') | Source/modules/cachestorage/Cache.cpp » ('j') | Source/modules/cachestorage/Cache.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/cachestorage/Cache.h

diff --git a/Source/modules/cachestorage/Cache.h b/Source/modules/cachestorage/Cache.h

index 0be17515ea72dc6f30f55c9881de8043b7f0771d..b9e11b544864bc7c4ffd9a7d26e8109d75d8bc3c 100644

--- a/Source/modules/cachestorage/Cache.h

+++ b/Source/modules/cachestorage/Cache.h

@@ -38,7 +38,7 @@ public:

ScriptPromise match(ScriptState*, const RequestInfo&, const CacheQueryOptions&, ExceptionState&);

ScriptPromise matchAll(ScriptState*, const RequestInfo&, const CacheQueryOptions&, ExceptionState&);

ScriptPromise add(ScriptState*, const RequestInfo&, ExceptionState&);

- ScriptPromise addAll(ScriptState*, const Vector<ScriptValue>&);

+ ScriptPromise addAll(ScriptState*, const HeapVector<RequestInfo>&, ExceptionState&);

ScriptPromise deleteFunction(ScriptState*, const RequestInfo&, const CacheQueryOptions&, ExceptionState&);

ScriptPromise put(ScriptState*, const RequestInfo&, Response*, ExceptionState&);

ScriptPromise keys(ScriptState*, ExceptionState&);

@@ -57,7 +57,7 @@ private:

ScriptPromise matchImpl(ScriptState*, const Request*, const CacheQueryOptions&);

ScriptPromise matchAllImpl(ScriptState*, const Request*, const CacheQueryOptions&);

- ScriptPromise addAllImpl(ScriptState*, const Vector<Request*>&, ExceptionState&);

+ ScriptPromise addAllImpl(ScriptState*, const HeapVector<Member<Request>>&, ExceptionState&);

ScriptPromise deleteImpl(ScriptState*, const Request*, const CacheQueryOptions&);

ScriptPromise putImpl(ScriptState*, const HeapVector<Member<Request>>&, const HeapVector<Member<Response>>&);

ScriptPromise keysImpl(ScriptState*);