Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1124403004: Files.app: Make the touch effect of sort button square. (Closed)

Created:
5 years, 7 months ago by fukino
Modified:
5 years, 7 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Make the touch effect of sort button square. As mentioned in Issue 480666, touch effect should be square. However, the newly-added sort button have the circle effect, so this CL fixes it. BUG=none TEST=manually Committed: https://crrev.com/2f5eaca8989774a7cf618ccf96b49ce6dff51a7b Cr-Commit-Position: refs/heads/master@{#329355}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/file_manager/file_manager/main.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
fukino
PTAL. Thanks!
5 years, 7 months ago (2015-05-12 03:40:28 UTC) #2
yawano
lgtm. Thank you!
5 years, 7 months ago (2015-05-12 03:46:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124403004/1
5 years, 7 months ago (2015-05-12 04:54:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 05:22:33 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 05:23:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2f5eaca8989774a7cf618ccf96b49ce6dff51a7b
Cr-Commit-Position: refs/heads/master@{#329355}

Powered by Google App Engine
This is Rietveld 408576698