Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Issue 1124393002: X87: Resolve references to "this" the same way as normal variables (Closed)

Created:
5 years, 7 months ago by chunyang.dai
Modified:
5 years, 7 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Resolve references to "this" the same way as normal variables port 06a792b7cc2db33ffce7244c044a9c05afbb6116 (r28263). original commit message: Make the parser handle references to "this" as unresolved variables, so the same logic as for the rest of function parameters is used for the receiver. Minor additions to the code generation handle copying the receiver to the context, along with the rest of the function parameters. Based on work by Adrian Perez de Castro <aperez@igalia.com>; BUG= Committed: https://crrev.com/c3529ce50158546e2f2c25ee888e7e0170a488f1 Cr-Commit-Position: refs/heads/master@{#28278}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M src/x87/full-codegen-x87.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL>
5 years, 7 months ago (2015-05-07 02:59:35 UTC) #2
Weiliang
lgtm
5 years, 7 months ago (2015-05-07 03:37:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124393002/1
5 years, 7 months ago (2015-05-07 03:38:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-07 04:00:01 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 04:00:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3529ce50158546e2f2c25ee888e7e0170a488f1
Cr-Commit-Position: refs/heads/master@{#28278}

Powered by Google App Engine
This is Rietveld 408576698