Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1124383009: Disables the TC for input time from OutputE2ETest.Input of chromevox_tests temporarily. (Closed)

Created:
5 years, 7 months ago by je_julie(Not used)
Modified:
5 years, 7 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, dtseng+watch_chromium.org, nkostylev+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disables the TC for input time from OutputE2ETest.Input of chromevox_tests temporarily. The TC for input time from OutputE2ETest.Input will be enabled again after adding AX TIME role. The related CL: https://codereview.chromium.org/1123313004/ https://codereview.chromium.org/1132963002/ BUG=480861 Committed: https://crrev.com/90eeda826604875b72b839d206f456fc4ef7a895 Cr-Commit-Position: refs/heads/master@{#330390}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
je_julie(Not used)
Hi Dominic, This patch disables OutputE2ETest.Input of chromevox_tests temporarily to add handling for AX role ...
5 years, 7 months ago (2015-05-17 14:11:12 UTC) #2
dmazzoni
lgtm This is fine, but for future reference you can also rename the test to ...
5 years, 7 months ago (2015-05-18 15:51:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124383009/1
5 years, 7 months ago (2015-05-18 15:51:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 20:15:50 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/90eeda826604875b72b839d206f456fc4ef7a895 Cr-Commit-Position: refs/heads/master@{#330390}
5 years, 7 months ago (2015-05-18 22:41:27 UTC) #7
je_julie(Not used)
5 years, 7 months ago (2015-05-18 23:57:11 UTC) #8
Message was sent while issue was closed.
On 2015/05/18 15:51:23, dmazzoni wrote:
> lgtm
> 
> This is fine, but for future reference you can also rename the test to
DISABLED
> just like in C++:
> 
> TEST_F('OutputE2ETest', 'DISABLED_Input', function() {

Thanks, Dominic.
I'll do that next time whenever I need to disable TC.

Powered by Google App Engine
This is Rietveld 408576698