Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1124383005: Exclude unsupported keycodes from X11 tests. (Closed)

Created:
5 years, 7 months ago by kpschoedel
Modified:
5 years, 7 months ago
Reviewers:
benwells, *sadrul
CC:
chromium-reviews, darin-cc_chromium.org, glider+watch_chromium.org, jam, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Exclude unsupported keycodes from X11 tests. BUG=487056 Committed: https://crrev.com/0dc50879a2b7b41320959cf064d3bddf13e109da Cr-Commit-Position: refs/heads/master@{#329478}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M content/browser/renderer_host/web_input_event_aura_unittest.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/valgrind/gtest_exclude/content_unittests.gtest.txt View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
kpschoedel
5 years, 7 months ago (2015-05-12 19:31:33 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124383005/1
5 years, 7 months ago (2015-05-12 19:32:32 UTC) #5
sadrul
lgtm There used to be a valgrind trybot ... can't find it right now though.
5 years, 7 months ago (2015-05-12 19:54:09 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-12 20:38:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124383005/1
5 years, 7 months ago (2015-05-12 20:39:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 20:44:56 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0dc50879a2b7b41320959cf064d3bddf13e109da Cr-Commit-Position: refs/heads/master@{#329478}
5 years, 7 months ago (2015-05-12 20:46:28 UTC) #12
benwells
5 years, 7 months ago (2015-05-12 22:54:46 UTC) #13
Message was sent while issue was closed. 
On 2015/05/12 20:46:28, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/0dc50879a2b7b41320959cf064d3bddf13e109da
> Cr-Commit-Position: refs/heads/master@{#329478}

valgrind looks happy with the change:
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28v...

Thanks kpschoedel!

Powered by Google App Engine
This is Rietveld 408576698