Removes the new-avatar-menu flags, enabling the feature for all users.

chrome/browser/about_flags.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/about_flags.h"
 
 #include <iterator>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 1543 matching lines @@
                               switches::kDisableAccountConsistency)
   },
   {
     "enable-fast-user-switching",
     IDS_FLAGS_ENABLE_FAST_USER_SWITCHING_NAME,
     IDS_FLAGS_ENABLE_FAST_USER_SWITCHING_DESCRIPTION,
     kOsMac | kOsWin | kOsLinux,
     SINGLE_VALUE_TYPE(switches::kFastUserSwitching)
   },
   {
-    "enable-new-avatar-menu",

[msw, 2015/05/18 18:28:30]

Can you take a look at the remaining mentions of this flag?
1) Monica's TODO at IDR_PROFILE_AVATAR_0:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/app/theme/t...
2) kEnableNewAvatarMenu:
https://code.google.com/p/chromium/codesearch#chromium/src/components/signin/...
3) The UpdateAvatar function comment at:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...
4) The source of this histograms.xml entry:
https://code.google.com/p/chromium/codesearch#chromium/src/tools/metrics/hist...

[anthonyvd, 2015/05/19 22:56:41]

We appear to still be using those resources in other places in the codebase. For
example,
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/pro...
references them and is called indirectly by profile_avatar_downloader and
profile_info_cache among others. We should investigate this further but I think
it's out of scope for this CL.
I left them in to be able to make this change without changing the rest of the
logic in this pass. The plan was to remove those as part of the clean up as
well.
The comment should probably be updated as this method will now only be a
function of the type of Browser (incognito vs regular) but I'd rather leave it
as-is until my cleanup pass, this way I'll know I'll come back there when
grepping for the flag.
Since it's an histogram enum, would the correct thing to do be to leave it as is
to not break past histograms (at least until all the data that refer to it
becomes outdated) or is it safe to remove it?

-    IDS_FLAGS_ENABLE_NEW_AVATAR_MENU_NAME,

[msw, 2015/05/18 18:28:30]

Remove these string resources.

[anthonyvd, 2015/05/19 22:56:41]

Good point, done.

-    IDS_FLAGS_ENABLE_NEW_AVATAR_MENU_DESCRIPTION,
-    kOsMac | kOsWin | kOsLinux,
-    ENABLE_DISABLE_VALUE_TYPE(switches::kEnableNewAvatarMenu,
-                              switches::kDisableNewAvatarMenu)
-  },
-  {
     "enable-iframe-based-signin",
     IDS_FLAGS_ENABLE_IFRAME_BASED_SIGNIN_NAME,
     IDS_FLAGS_ENABLE_IFRAME_BASED_SIGNIN_DESCRIPTION,
     kOsMac | kOsWin | kOsLinux,
     SINGLE_VALUE_TYPE(switches::kEnableIframeBasedSignin)
   },
   {
     "enable-google-profile-info",
     IDS_FLAGS_ENABLE_GOOGLE_PROFILE_INFO_NAME,
     IDS_FLAGS_ENABLE_GOOGLE_PROFILE_INFO_DESCRIPTION,
@@ skipping 1432 matching lines @@
 }
 
 const Experiment* GetExperiments(size_t* count) {
   *count = num_experiments;
   return experiments;
 }
 
 }  // namespace testing
 
 }  // namespace about_flags