Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1124343004: docs: Fix some broken links to samples where the #hash-word is supposed to be a search term. (Closed)

Created:
5 years, 7 months ago by lazyboy
Modified:
5 years, 7 months ago
CC:
Mike West, aandrey+blink_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, devtools-reviews_chromium.org, extensions-reviews_chromium.org, pfeldman, vasilii, yurys
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

docs: Fix some broken links to samples where the #hash-word is supposed to be a search term. BUG=486488 Test=Check some link that has search term, e.g. https://developer.chrome.com/extensions/browsingData#samples click on the "on the samples page" link. Committed: https://crrev.com/381a0de69887094c355815fb8d0b29266c3e9f0f Cr-Commit-Position: refs/heads/master@{#329264}

Patch Set 1 #

Patch Set 2 : revert wrong mappy link update #

Total comments: 4

Patch Set 3 : change TODO owners #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -15 lines) Patch
M chrome/common/extensions/docs/templates/articles/content_scripts.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/articles/experimental.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/articles/override.html View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/intros/browsingData.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/intros/contentSettings.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/intros/contextMenus.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/intros/debugger.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/intros/devtools_inspectedWindow.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/intros/devtools_network.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/intros/experimental_devtools_audits.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/intros/omnibox.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/intros/privacy.html View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/intros/topSites.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/intros/webRequest.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/private/api_reference.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
lazyboy
I've ran "git gs samples#" from src/chrome/common/extensions/docs to search for broken links. There are couple ...
5 years, 7 months ago (2015-05-11 20:19:35 UTC) #2
not at google - send to devlin
lgtm https://chromiumcodereview.appspot.com/1124343004/diff/20001/chrome/common/extensions/docs/templates/articles/override.html File chrome/common/extensions/docs/templates/articles/override.html (right): https://chromiumcodereview.appspot.com/1124343004/diff/20001/chrome/common/extensions/docs/templates/articles/override.html#newcode185 chrome/common/extensions/docs/templates/articles/override.html:185: <!-- TODO(kalman): Fix broken link. --> Could you ...
5 years, 7 months ago (2015-05-11 20:57:00 UTC) #3
lazyboy
5 years, 7 months ago (2015-05-11 21:14:23 UTC) #4
lazyboy
Patch Set #3 https://chromiumcodereview.appspot.com/1124343004/diff/20001/chrome/common/extensions/docs/templates/articles/override.html File chrome/common/extensions/docs/templates/articles/override.html (right): https://chromiumcodereview.appspot.com/1124343004/diff/20001/chrome/common/extensions/docs/templates/articles/override.html#newcode185 chrome/common/extensions/docs/templates/articles/override.html:185: <!-- TODO(kalman): Fix broken link. --> ...
5 years, 7 months ago (2015-05-11 21:14:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124343004/40001
5 years, 7 months ago (2015-05-11 22:21:34 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-11 22:54:59 UTC) #9
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/381a0de69887094c355815fb8d0b29266c3e9f0f Cr-Commit-Position: refs/heads/master@{#329264}
5 years, 7 months ago (2015-05-11 22:56:43 UTC) #10
Mike West
5 years, 7 months ago (2015-05-12 03:09:22 UTC) #12
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698