Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 1124333013: PPC: Fix '[strong] Disallow implicit conversions for comparison' (Closed)

Created:
5 years, 7 months ago by MTBrandyberry
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Fix '[strong] Disallow implicit conversions for comparison' Do not trash type register in kIsNotStringMask test. R=conradw@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/483436219f6689d49153afb264b766f0d6d7cefb Cr-Commit-Position: refs/heads/master@{#28375}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/ppc/code-stubs-ppc.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 7 months ago (2015-05-12 16:12:06 UTC) #1
dstence
lgtm
5 years, 7 months ago (2015-05-12 16:20:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124333013/1
5 years, 7 months ago (2015-05-12 16:21:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 16:48:21 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 16:48:33 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/483436219f6689d49153afb264b766f0d6d7cefb
Cr-Commit-Position: refs/heads/master@{#28375}

Powered by Google App Engine
This is Rietveld 408576698