Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Unified Diff: chrome/browser/profiles/profile_io_data.h

Issue 1124333010: Shut down Profile's URLRequestContextGetters safely. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fetcher
Patch Set: Cleanup Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_io_data.h
diff --git a/chrome/browser/profiles/profile_io_data.h b/chrome/browser/profiles/profile_io_data.h
index 38ffe6e1809466b41a17a1d70b0b8a4d2889bbf4..95b8a92466189414c2511299b0c56f2b58dbd84e 100644
--- a/chrome/browser/profiles/profile_io_data.h
+++ b/chrome/browser/profiles/profile_io_data.h
@@ -328,7 +328,12 @@ class ProfileIOData {
net::NetworkDelegate* network_delegate,
net::FtpTransactionFactory* ftp_transaction_factory) const;
- // Called when the profile is destroyed.
+ // Called when the Profile is destroyed. |context_getters| must include all
+ // URLRequestContextGetters that refer to the ProfileIOData's
+ // URLRequestContexts. Triggers destruction of the ProfileIOData and shuts
+ // down |context_getters| safely on the IO thread.
+ // TODO(mmenke): Passing all those URLRequestContextGetters around like this
+ // is really silly. Can we do something cleaner?
void ShutdownOnUIThread(
scoped_ptr<ChromeURLRequestContextGetterVector> context_getters);

Powered by Google App Engine
This is Rietveld 408576698