Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2173)

Unified Diff: chrome/browser/net/chrome_url_request_context_getter.h

Issue 1124333010: Shut down Profile's URLRequestContextGetters safely. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fetcher
Patch Set: Cleanup Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/chrome_url_request_context_getter.h
diff --git a/chrome/browser/net/chrome_url_request_context_getter.h b/chrome/browser/net/chrome_url_request_context_getter.h
index d9cff5020855d36eef7533b31ed1f921d49f3a61..31b5c309e46d52de76cfcee94f8fb033fa186e5e 100644
--- a/chrome/browser/net/chrome_url_request_context_getter.h
+++ b/chrome/browser/net/chrome_url_request_context_getter.h
@@ -79,9 +79,9 @@ class ChromeURLRequestContextGetter : public net::URLRequestContextGetter {
const ProfileIOData* profile_io_data,
const StoragePartitionDescriptor& partition_descriptor);
- // Discard reference to URLRequestContext.
- // Access only from the IO thread.
- void Invalidate();
+ // Discard reference to URLRequestContext and inform observers of shutdown.
+ // Must be called before destruction. May only be called on IO thread.
+ void NotifyContextShuttingDown();
davidben 2015/05/14 17:09:26 Maybe keep this called Invalidate or rename it to
mmenke 2015/05/14 19:23:52 Done - was on the fence about naming, happy to def
private:
~ChromeURLRequestContextGetter() override;
« no previous file with comments | « no previous file | chrome/browser/net/chrome_url_request_context_getter.cc » ('j') | chrome/browser/profiles/profile_browsertest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698