Rename CronetUploadDataStreamAdapter to CronetUploadDataStream.

Rename CronetUploadDataStreamAdapter to CronetUploadDataStream.

Will rename CronetUploadDataStreamDelegate to
CronetUploadDataStreamAdapter in a followup CL.

BUG=481119
Committed: https://crrev.com/3eea47aeb4d4111ad0e5f3c4f6933cc9dae151eb
Cr-Commit-Position: refs/heads/master@{#329926}

[mmenke, 2015-05-08 19:16:59]

mmenke@chromium.org changed reviewers:
+ xunjieli@chromium.org

[mmenke, 2015-05-08 19:17:00]

Started this a while back, but forgot about it.

[xunjieli, 2015-05-08 20:11:28]

Thanks for doing this! The change looks really good. Just some minor issues
below. Will take another look once you fixed those.

https://codereview.chromium.org/1124333003/diff/1/components/cronet/android/c...
File components/cronet/android/cronet_upload_data_stream.h (right):

https://codereview.chromium.org/1124333003/diff/1/components/cronet/android/c...
components/cronet/android/cronet_upload_data_stream.h:45: // Called when the
adapter is destroyed. May be called when there's a
nit: s/adapter/upload stream.

https://codereview.chromium.org/1124333003/diff/1/components/cronet/android/c...
File components/cronet/android/cronet_upload_data_stream_delegate.cc (right):

https://codereview.chromium.org/1124333003/diff/1/components/cronet/android/c...
components/cronet/android/cronet_upload_data_stream_delegate.cc:67: // If the
CronetUploadDataStream was never initialized, |upload_data_stream_|
nit: After the name changes, this comment is not so clear.
Suggest change to something like: "If CronetUploadDataStream::InitInternal was
never called.." to make it clearer that the first one refers to the C++ object.

https://codereview.chromium.org/1124333003/diff/1/components/cronet/android/c...
File components/cronet/android/cronet_upload_data_stream_delegate.h (right):

https://codereview.chromium.org/1124333003/diff/1/components/cronet/android/c...
components/cronet/android/cronet_upload_data_stream_delegate.h:28: // reference
to it. The Delegate is only destroyed after the URLRequest
nit: not related to this CL. But could you change "URLRequest" to
"net::URLRequest" to make it clearer that the object is a C++ object and belongs
to the net layer?

https://codereview.chromium.org/1124333003/diff/1/components/cronet/android/j...
File
components/cronet/android/java/src/org/chromium/net/CronetUploadDataStream.java
(right):

https://codereview.chromium.org/1124333003/diff/1/components/cronet/android/j...
components/cronet/android/java/src/org/chromium/net/CronetUploadDataStream.java:119:
* adapter is destroyed.
nit: need to update the comment.

https://codereview.chromium.org/1124333003/diff/1/components/cronet/android/j...
components/cronet/android/java/src/org/chromium/net/CronetUploadDataStream.java:152:
// while reading. This should be safe, even if we deleted the adapter,
nit: s/"adapter"/"native UploadDataStream" to match the rest of the naming in
this file.

https://codereview.chromium.org/1124333003/diff/1/components/cronet/android/j...
components/cronet/android/java/src/org/chromium/net/CronetUploadDataStream.java:279:
// Native methods are implemented in upload_data_stream_adapter.cc.
nit: need to update file name here.

https://codereview.chromium.org/1124333003/diff/1/components/cronet/android/t...
File
components/cronet/android/test/javatests/src/org/chromium/net/CronetUploadTest.java
(right):

https://codereview.chromium.org/1124333003/diff/1/components/cronet/android/t...
components/cronet/android/test/javatests/src/org/chromium/net/CronetUploadTest.java:51:
"Cronet" })
Strange that this formatting got changed somehow. Maybe revert this and below.

https://codereview.chromium.org/1124333003/diff/1/components/cronet/android/t...
components/cronet/android/test/javatests/src/org/chromium/net/CronetUploadTest.java:248:
// Destroy the C++ TestUploadDataStreamHandler.  The handler will then
nit: there are two spaces after the dot.

https://codereview.chromium.org/1124333003/diff/1/components/cronet/android/t...
components/cronet/android/test/javatests/src/org/chromium/net/CronetUploadTest.java:293:
// Destroy the C++ TestUploadDataStreamHandler.  The handler will then
nit: there are two spaces after the dot.

[mmenke, 2015-05-08 20:24:19]

Thanks for the feedback!

https://codereview.chromium.org/1124333003/diff/1/components/cronet/android/c...
File components/cronet/android/cronet_upload_data_stream.h (right):

https://codereview.chromium.org/1124333003/diff/1/components/cronet/android/c...
components/cronet/android/cronet_upload_data_stream.h:45: // Called when the
adapter is destroyed. May be called when there's a
On 2015/05/08 20:11:27, xunjieli wrote:
> nit: s/adapter/upload stream.

Done (I actually already got that one, but git cl ate my second patch set upload
attempt with a warning that I missed).

https://codereview.chromium.org/1124333003/diff/1/components/cronet/android/c...
File components/cronet/android/cronet_upload_data_stream_delegate.cc (right):

https://codereview.chromium.org/1124333003/diff/1/components/cronet/android/c...
components/cronet/android/cronet_upload_data_stream_delegate.cc:67: // If the
CronetUploadDataStream was never initialized, |upload_data_stream_|
On 2015/05/08 20:11:27, xunjieli wrote:
> nit: After the name changes, this comment is not so clear.
> Suggest change to something like: "If CronetUploadDataStream::InitInternal was
> never called.." to make it clearer that the first one refers to the C++
object. 

Done.

https://codereview.chromium.org/1124333003/diff/1/components/cronet/android/c...
File components/cronet/android/cronet_upload_data_stream_delegate.h (right):

https://codereview.chromium.org/1124333003/diff/1/components/cronet/android/c...
components/cronet/android/cronet_upload_data_stream_delegate.h:28: // reference
to it. The Delegate is only destroyed after the URLRequest
On 2015/05/08 20:11:27, xunjieli wrote:
> nit: not related to this CL. But could you change "URLRequest" to
> "net::URLRequest" to make it clearer that the object is a C++ object and
belongs
> to the net layer?

Done.

https://codereview.chromium.org/1124333003/diff/1/components/cronet/android/j...
File
components/cronet/android/java/src/org/chromium/net/CronetUploadDataStream.java
(right):

https://codereview.chromium.org/1124333003/diff/1/components/cronet/android/j...
components/cronet/android/java/src/org/chromium/net/CronetUploadDataStream.java:119:
* adapter is destroyed.
On 2015/05/08 20:11:27, xunjieli wrote:
> nit: need to update the comment.

Done.

https://codereview.chromium.org/1124333003/diff/1/components/cronet/android/j...
components/cronet/android/java/src/org/chromium/net/CronetUploadDataStream.java:152:
// while reading. This should be safe, even if we deleted the adapter,
On 2015/05/08 20:11:27, xunjieli wrote:
> nit: s/"adapter"/"native UploadDataStream" to match the rest of the naming in
> this file.

Done.

https://codereview.chromium.org/1124333003/diff/1/components/cronet/android/j...
components/cronet/android/java/src/org/chromium/net/CronetUploadDataStream.java:279:
// Native methods are implemented in upload_data_stream_adapter.cc.
On 2015/05/08 20:11:27, xunjieli wrote:
> nit: need to update file name here.

Done.

https://codereview.chromium.org/1124333003/diff/1/components/cronet/android/t...
File
components/cronet/android/test/javatests/src/org/chromium/net/CronetUploadTest.java
(right):

https://codereview.chromium.org/1124333003/diff/1/components/cronet/android/t...
components/cronet/android/test/javatests/src/org/chromium/net/CronetUploadTest.java:51:
"Cronet" })
On 2015/05/08 20:11:28, xunjieli wrote:
> Strange that this formatting got changed somehow. Maybe revert this and below.

Done.  No idea how that happened.

https://codereview.chromium.org/1124333003/diff/1/components/cronet/android/t...
components/cronet/android/test/javatests/src/org/chromium/net/CronetUploadTest.java:248:
// Destroy the C++ TestUploadDataStreamHandler.  The handler will then
On 2015/05/08 20:11:27, xunjieli wrote:
> nit: there are two spaces after the dot.

Done.

https://codereview.chromium.org/1124333003/diff/1/components/cronet/android/t...
components/cronet/android/test/javatests/src/org/chromium/net/CronetUploadTest.java:293:
// Destroy the C++ TestUploadDataStreamHandler.  The handler will then
On 2015/05/08 20:11:28, xunjieli wrote:
> nit: there are two spaces after the dot.

Done.

[xunjieli, 2015-05-08 20:30:25]

LGTM! thanks

[mmenke, 2015-05-08 20:35:04]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2015-05-08 20:38:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1124333003/40001

[commit-bot: I haz the power, 2015-05-09 00:57:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-09 00:57:11]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mmenke, 2015-05-14 17:56:54]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2015-05-14 17:57:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1124333003/40001

[commit-bot: I haz the power, 2015-05-14 18:03:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-14 18:03:36]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mmenke, 2015-05-14 19:32:13]

The CQ bit was checked by mmenke@chromium.org

[mmenke, 2015-05-14 19:32:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
xunjieli@chromium.org
Link to the patchset: https://codereview.chromium.org/1124333003/#ps60001
(title: "Sync")

[commit-bot: I haz the power, 2015-05-14 19:34:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1124333003/60001

[commit-bot: I haz the power, 2015-05-14 20:43:46]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-05-14 20:44:33]

Patchset 4 (id:??) landed as
https://crrev.com/3eea47aeb4d4111ad0e5f3c4f6933cc9dae151eb
Cr-Commit-Position: refs/heads/master@{#329926}