Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: chrome/browser/android/compositor/tab_content_manager.h

Issue 1124333002: Refactor TabContentManager to async create ThumbnailCache. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/compositor/tab_content_manager.h
diff --git a/chrome/browser/android/compositor/tab_content_manager.h b/chrome/browser/android/compositor/tab_content_manager.h
index df4f89749c118acb4679f88a55aebc372be62113..e6e28417c07fa409b5fa4fdcb46e419a033f7c41 100644
--- a/chrome/browser/android/compositor/tab_content_manager.h
+++ b/chrome/browser/android/compositor/tab_content_manager.h
@@ -37,13 +37,7 @@ class TabContentManager : public ThumbnailCacheObserver {
static TabContentManager* FromJavaObject(jobject jobj);
TabContentManager(JNIEnv* env,
- jobject obj,
- jstring disk_cache_path,
- jint default_cache_size,
- jint approximation_cache_size,
- jint compression_queue_max_size,
- jint write_queue_max_size,
- jboolean use_approximation_thumbnail);
+ jobject obj);
virtual ~TabContentManager();
@@ -73,6 +67,14 @@ class TabContentManager : public ThumbnailCacheObserver {
// Callback for when the thumbnail decompression for tab_id is done.
void OnFinishDecompressThumbnail(int tab_id, bool success, SkBitmap bitmap);
// JNI methods.
+ void CreateThumbnailCache(JNIEnv* env,
+ jobject obj,
+ jstring disk_cache_path,
+ jint default_cache_size,
+ jint approximation_cache_size,
+ jint compression_queue_max_size,
+ jint write_queue_max_size,
+ jboolean use_approximation_thumbnail);
jboolean HasFullCachedThumbnail(JNIEnv* env, jobject obj, jint tab_id);
void CacheTab(JNIEnv* env,
jobject obj,
@@ -102,6 +104,7 @@ class TabContentManager : public ThumbnailCacheObserver {
typedef base::ScopedPtrHashMap<int, scoped_ptr<TabReadbackRequest>>
TabReadbackRequestMap;
+ ThumbnailCache* GetThumbnailCache();
void PutThumbnailIntoCache(int tab_id,
float thumbnail_scale,
const SkBitmap& bitmap);

Powered by Google App Engine
This is Rietveld 408576698