Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1124323004: Update some more webui progress indicators to new throbber: (Closed)

Created:
5 years, 7 months ago by Evan Stade
Modified:
5 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, Patrick Dubroy, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update some more webui progress indicators to new throbber: - history - clear browsing data - print preview This should cover all known spinners for desktop Chrome (save OSX, which shrike@ is working on). spinner.svg is not deleted from the repo because some cros files still reference it. BUG=259556 Committed: https://crrev.com/4946cdff810e6322c5973fecbeef2c8588a24ade Cr-Commit-Position: refs/heads/master@{#328822}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : fix cbd a little #

Patch Set 4 : can't get rid of .grd entry yet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -48 lines) Patch
M chrome/browser/resources/history/history.css View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/clear_browser_data_overlay.css View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/print_preview/settings/destination_settings.css View 1 chunk +1 line, -3 lines 0 comments Download
M ui/webui/resources/css/spinner.css View 2 chunks +1 line, -41 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Evan Stade
5 years, 7 months ago (2015-05-07 00:45:47 UTC) #2
Dan Beam
can you show me the specific styling you did (e.g. print preview) on your computer? ...
5 years, 7 months ago (2015-05-07 01:21:23 UTC) #3
Evan Stade
https://codereview.chromium.org/1124323004/diff/20001/ui/webui/resources/webui_resources.grd File ui/webui/resources/webui_resources.grd (left): https://codereview.chromium.org/1124323004/diff/20001/ui/webui/resources/webui_resources.grd#oldcode198 ui/webui/resources/webui_resources.grd:198: file="images/spinner.svg" type="BINDATA" /> On 2015/05/07 01:21:22, Dan Beam wrote: ...
5 years, 7 months ago (2015-05-07 03:10:24 UTC) #4
Dan Beam
lgtm
5 years, 7 months ago (2015-05-07 03:11:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124323004/40001
5 years, 7 months ago (2015-05-07 03:14:01 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/54701)
5 years, 7 months ago (2015-05-07 04:53:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124323004/60001
5 years, 7 months ago (2015-05-07 19:54:45 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-07 20:59:13 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 21:00:31 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4946cdff810e6322c5973fecbeef2c8588a24ade
Cr-Commit-Position: refs/heads/master@{#328822}

Powered by Google App Engine
This is Rietveld 408576698