Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 1124313003: Replace NC_AUTO_SUBFRAME renderer kill with NOTREACHED for now. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigation_controller_impl.cc
diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc
index 110cebfb8aee20f695e2fbd5d286997903d4c9e4..8339b73051bb2defae2e97b72f3f54927091fca3 100644
--- a/content/browser/frame_host/navigation_controller_impl.cc
+++ b/content/browser/frame_host/navigation_controller_impl.cc
@@ -1461,8 +1461,11 @@ bool NavigationControllerImpl::RendererDidNavigateAutoSubframe(
// We can't check the path since that may change (https://crbug.com/373041).
if (GetLastCommittedEntry()->GetURL().GetOrigin() !=
GetEntryAtIndex(entry_index)->GetURL().GetOrigin()) {
- bad_message::ReceivedBadMessage(rfh->GetProcess(),
- bad_message::NC_AUTO_SUBFRAME);
+ // TODO(creis): This is unexpectedly being encountered in practice. If
+ // you encounter this in practice, please post details to
+ // https://crbug.com/486916. Once that's resolved, we'll change this to
+ // kill the renderer process with bad_message::NC_AUTO_SUBFRAME.
+ NOTREACHED() << "Unexpected main frame origin change on AUTO_SUBFRAME.";
}
last_committed_entry_index_ = entry_index;
DiscardNonCommittedEntriesInternal();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698