Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Issue 1124313003: Replace NC_AUTO_SUBFRAME renderer kill with NOTREACHED for now. (Closed)

Created:
5 years, 7 months ago by Charlie Reis
Modified:
5 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace NC_AUTO_SUBFRAME renderer kill with NOTREACHED for now. BUG=486916 TEST=No more NC_AUTO_SUBFRAME renderer kills. Committed: https://crrev.com/7be9d959519cdea906d3e683d28567e86e8a93fe Cr-Commit-Position: refs/heads/master@{#329938}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M content/browser/frame_host/navigation_controller_impl.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Charlie Reis
This should get rid of the renderer kills for the branch cut, after which I'll ...
5 years, 7 months ago (2015-05-14 20:21:37 UTC) #2
Avi (use Gerrit)
lgtm Yep. Happy branches yield happy people.
5 years, 7 months ago (2015-05-14 20:56:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124313003/1
5 years, 7 months ago (2015-05-14 21:29:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 21:37:58 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 21:39:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7be9d959519cdea906d3e683d28567e86e8a93fe
Cr-Commit-Position: refs/heads/master@{#329938}

Powered by Google App Engine
This is Rietveld 408576698