net/proxy/proxy_resolver_v8_unittest.cc - Issue 1124293003: Fix ProxyResolverV8Test after V8 roll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_resolver_v8_unittest.cc

Issue 1124293003: Fix ProxyResolverV8Test after V8 roll (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/proxy/proxy_resolver_v8_unittest.cc

diff --git a/net/proxy/proxy_resolver_v8_unittest.cc b/net/proxy/proxy_resolver_v8_unittest.cc

index 204eb63cbc5b88d6441511f2f6ec646db2065972..37992ceab74710940b4e1c9cd4914d8c59b1ac40 100644

--- a/net/proxy/proxy_resolver_v8_unittest.cc

+++ b/net/proxy/proxy_resolver_v8_unittest.cc

@@ -283,8 +283,7 @@ TEST(ProxyResolverV8Test, ParseError) {

EXPECT_EQ("Uncaught SyntaxError: Unexpected end of input",

bindings->errors[0]);

- // TODO: replace expected value with 5 after V8 roll

- // EXPECT_EQ(0, bindings->errors_line_number[0]);

+ EXPECT_EQ(5, bindings->errors_line_number[0]);

}

// Run a PAC script several times, which has side-effects.

« no previous file with comments | « no previous file | no next file » | no next file with comments »