Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1124293002: Shard v8_base.lib on Windows to avoid 2G .lib limit (Closed)

Created:
5 years, 7 months ago by scottmg
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Shard v8_base.lib on Windows to avoid 2G .lib limit R=jochen@chromium.org BUG=chromium:485155 LOG=y Committed: https://crrev.com/addbe75e199eb28d8255f83bce75852ea1b17943 Cr-Commit-Position: refs/heads/master@{#28276}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/gyp/v8.gyp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scottmg
5 years, 7 months ago (2015-05-06 19:16:44 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-06 19:23:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124293002/1
5 years, 7 months ago (2015-05-06 19:24:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-06 19:40:10 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 19:40:21 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/addbe75e199eb28d8255f83bce75852ea1b17943
Cr-Commit-Position: refs/heads/master@{#28276}

Powered by Google App Engine
This is Rietveld 408576698