content/browser/renderer_host/media/video_capture_host.cc - Issue 1124263004: New resolution change policies for desktop and tab capture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/video_capture_host.cc

Issue 1124263004: New resolution change policies for desktop and tab capture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Inlined operator==(). Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/media/capture/desktop_capture_device.cc ('k') | content/renderer/media/media_stream_video_capture_source_unittest.cc » ('j') | content/renderer/media/media_stream_video_capturer_source.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/video_capture_host.cc

diff --git a/content/browser/renderer_host/media/video_capture_host.cc b/content/browser/renderer_host/media/video_capture_host.cc

index 72e440cd2e928688413a2aeea61e37a36784962c..a546bbd26ab14525d51415b604b25d39942d9fad 100644

--- a/content/browser/renderer_host/media/video_capture_host.cc

+++ b/content/browser/renderer_host/media/video_capture_host.cc

@@ -180,8 +180,11 @@ void VideoCaptureHost::OnStartCapture(int device_id,

<< ", format=" << params.requested_format.ToString()

<< "@" << params.requested_format.frame_rate

<< " (" << (params.resolution_change_policy ==

mcasas 2015/05/07 22:10:00 Nit: this parenthesis isn't matched.

miu 2015/05/08 06:43:34 Assuming you're talking about the parentheses in t

mcasas 2015/05/08 18:38:41 Oops you're right, I missed l.188. Forget my comme

- media::RESOLUTION_POLICY_DYNAMIC_WITHIN_LIMIT ?

- "variable" : "constant")

+ media::RESOLUTION_POLICY_FIXED_RESOLUTION ?

+ "fixed resolution" :

+ (params.resolution_change_policy ==

+ media::RESOLUTION_POLICY_FIXED_ASPECT_RATIO ?

+ "fixed aspect ratio" : "variable resolution"))

<< ")";

VideoCaptureControllerID controller_id(device_id);

if (entries_.find(controller_id) != entries_.end()) {