runtime/vm/class_finalizer.cc - Issue 1124253004: Make sure the bound of a mixin type parameter is finalized before instantiating

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/class_finalizer.cc

Issue 1124253004: Make sure the bound of a mixin type parameter is finalized before instantiating (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/class_finalizer.cc

===================================================================

--- runtime/vm/class_finalizer.cc (revision 45585)

+++ runtime/vm/class_finalizer.cc (working copy)

@@ -1683,6 +1683,13 @@

param ^= mixin_type_args.TypeAt(i);

param_bound = param.bound();

if (!param_bound.IsInstantiated()) {

+ // Make sure the bound is finalized before instantiating it.

+ if (!param_bound.IsFinalized() &&

+ !param_bound.IsBeingFinalized()) {

+ param_bound =

+ FinalizeType(mixin_app_class, param_bound, kCanonicalize);

+ param.set_bound(param_bound); // In case part of recursive type.

+ }

param_bound = param_bound.InstantiateFrom(mixin_type_args,

&bound_error);

// The instantiator contains only TypeParameter objects and no

« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | no next file with comments »