Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1124243002: PPC: Optimize the typeof operator. (Closed)

Created:
5 years, 7 months ago by MTBrandyberry
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Optimize the typeof operator. Port 7798548a8f2ef14e8320cc42effa86f0eb8e4294 Original commit message: typeof was implemented as a runtime function. Calling it in optimized code with a non-constant input becomes burdensome. R=mvstanton@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/04b0a96b2b692ad4ff096108a9a5af9b31ec1d24 Cr-Commit-Position: refs/heads/master@{#28273}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
M src/ppc/code-stubs-ppc.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 1 chunk +11 lines, -3 lines 0 comments Download
M src/ppc/lithium-ppc.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 7 months ago (2015-05-06 15:50:00 UTC) #1
dstence
lgtm
5 years, 7 months ago (2015-05-06 15:57:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124243002/1
5 years, 7 months ago (2015-05-06 16:03:09 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-06 16:45:56 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 16:46:13 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04b0a96b2b692ad4ff096108a9a5af9b31ec1d24
Cr-Commit-Position: refs/heads/master@{#28273}

Powered by Google App Engine
This is Rietveld 408576698