clang/win: Fix last plugin warnings in component builds.

clang/win: Fix last plugin warnings in component builds.

Exporting a class on Windows forces instantiation of default constructor,
copy constructor, and sundry similar other functions.  The clang plugin then
complains about these not being out-of-line, even if they're not referred to
from anywhere.  Since having this only on Windows is annoying, we're suppressing
these warnings on exported classes.

In this case however, the inner classes STSState and PKPState aren't exported,
and their copy constructors are only instantiated because their outer class
_is_ exported and has STSState and PKPState members.  This cannot be easily
suppressed, and it's also the only place in the whole codebase where this
happens.

So just export these two structs to make the plugin happy in Windows
component builds.

BUG=467287, 483986
Committed: https://crrev.com/07b68b6b552c8a12d4e0db3a32fbd4b118275342
Cr-Commit-Position: refs/heads/master@{#329483}

[Nico, 2015-05-12 18:40:49]

thakis@chromium.org changed reviewers:
+ davidben@chromium.org

[davidben, 2015-05-12 19:10:30]

Would it be better to export those two classes instead? Given that DomainState
is also exported, not exporting STSState and PKPState was probably an oversight
on my part. I suppose it works fine right now, but DomainState should be split
into STSState and PKPState.

(The backstory here is that HSTS and HPKP used to be part of the same ball of
state and, partway through standardization, they made it completely orthogonal.
I fixed the orthogonality, but haven't yet fixed our in-memory and on-disk
representations.)

https://codereview.chromium.org/1124233005/diff/20001/net/http/transport_secu...
File net/http/transport_security_state.h (right):

https://codereview.chromium.org/1124233005/diff/20001/net/http/transport_secu...
net/http/transport_security_state.h:71: STSState(const STSState& rhs);
Probably worth a comment for why this silliness is needed.

[Nico, 2015-05-12 19:28:56]

Changed to export the inner classes instead.

[davidben, 2015-05-12 19:29:58]

lgtm

[Nico, 2015-05-12 19:31:11]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-05-12 19:32:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1124233005/40001

[commit-bot: I haz the power, 2015-05-12 20:56:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-12 20:57:07]

Patchset 3 (id:??) landed as
https://crrev.com/07b68b6b552c8a12d4e0db3a32fbd4b118275342
Cr-Commit-Position: refs/heads/master@{#329483}