Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 1124233002: Remove Scope::scope_uses_arguments_ flag (Closed)

Created:
5 years, 7 months ago by wingo
Modified:
5 years, 7 months ago
CC:
v8-dev, rossberg, Dmitry Lomov (no reviews)
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove Scope::scope_uses_arguments_ flag Use of arguments is tracked as a variable, like any other variable. R=arv@chromium.org LOG=N BUG= Committed: https://crrev.com/d4ea33f480243fb5b7d2cca6edddcaa3e9478e29 Cr-Commit-Position: refs/heads/master@{#28271}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -30 lines) Patch
M src/preparser.h View 3 chunks +0 lines, -3 lines 0 comments Download
M src/scopes.h View 4 chunks +0 lines, -10 lines 0 comments Download
M src/scopes.cc View 5 chunks +0 lines, -10 lines 0 comments Download
M test/cctest/test-parsing.cc View 4 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
wingo
5 years, 7 months ago (2015-05-06 15:31:19 UTC) #1
arv (Not doing code reviews)
LGTM
5 years, 7 months ago (2015-05-06 15:39:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124233002/1
5 years, 7 months ago (2015-05-06 15:53:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-06 16:25:23 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d4ea33f480243fb5b7d2cca6edddcaa3e9478e29 Cr-Commit-Position: refs/heads/master@{#28271}
5 years, 7 months ago (2015-05-06 16:25:33 UTC) #6
Michael Achenbach
5 years, 7 months ago (2015-05-07 07:41:59 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1134453002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Need to fix compilation after this
revert:
https://chromium.googlesource.com/v8/v8/+/5cab6be83a44567a3ee5747d728a399025d....

Powered by Google App Engine
This is Rietveld 408576698