Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1124223006: [clusterfuzz] Length 0 is perfectly fine for BitVector. (Closed)

Created:
5 years, 7 months ago by Benedikt Meurer
Modified:
5 years, 7 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[clusterfuzz] Length 0 is perfectly fine for BitVector. BUG=chromium:485952 LOG=n R=jarin@chromium.org Committed: https://crrev.com/297bb0ca8bcd5889d389e3c51324fda8aa038734 Cr-Commit-Position: refs/heads/master@{#28316}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M src/bit-vector.h View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 7 months ago (2015-05-08 11:28:12 UTC) #1
Benedikt Meurer
Hey Jaro, The DCHECK is bogus. Please take a look. Thanks, Benedikt
5 years, 7 months ago (2015-05-08 11:28:49 UTC) #2
Jarin
lgtm
5 years, 7 months ago (2015-05-08 11:36:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124223006/1
5 years, 7 months ago (2015-05-08 11:36:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-08 12:01:51 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-08 12:02:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/297bb0ca8bcd5889d389e3c51324fda8aa038734
Cr-Commit-Position: refs/heads/master@{#28316}

Powered by Google App Engine
This is Rietveld 408576698