Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1124193003: SkPDF: Move utility fns to SkPDFUtils (Closed)

Created:
5 years, 7 months ago by hal.canary
Modified:
5 years, 7 months ago
Reviewers:
tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 : 2015-05-06 (Wednesday) 13:16:21 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -137 lines) Patch
M src/pdf/SkPDFDevice.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M src/pdf/SkPDFFont.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFTypes.h View 1 chunk +1 line, -11 lines 0 comments Download
M src/pdf/SkPDFTypes.cpp View 4 chunks +4 lines, -100 lines 0 comments Download
M src/pdf/SkPDFUtils.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/pdf/SkPDFUtils.cpp View 6 chunks +107 lines, -16 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
hal.canary
ptal
5 years, 7 months ago (2015-05-06 17:12:02 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124193003/1
5 years, 7 months ago (2015-05-06 17:12:20 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/903)
5 years, 7 months ago (2015-05-06 17:13:36 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124193003/20001
5 years, 7 months ago (2015-05-06 17:16:58 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-06 17:26:39 UTC) #10
tomhudson
Hmm. I suppose I asked for this, so I ought to be happy with it. ...
5 years, 7 months ago (2015-05-06 17:55:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124193003/20001
5 years, 7 months ago (2015-05-06 17:55:52 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 17:56:12 UTC) #15
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) as
https://skia.googlesource.com/skia/+/bc4696b9176e05940a7c2d6778276cdbc55ccd61

Powered by Google App Engine
This is Rietveld 408576698