Plugin Power Saver: Unthrottle dynamically sized plugins correctly.

content/renderer/pepper/plugin_power_saver_helper.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper/plugin_power_saver_helper.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/string_number_conversions.h"
 #include "content/common/frame_messages.h"
 #include "content/public/common/content_constants.h"
 #include "content/public/common/content_switches.h"
+#include "content/public/renderer/plugin_instance_throttler.h"
 #include "content/public/renderer/render_frame.h"
 #include "ppapi/shared_impl/ppapi_constants.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebLocalFrame.h"
 #include "third_party/WebKit/public/web/WebPluginParams.h"
 #include "third_party/WebKit/public/web/WebView.h"
 
 namespace content {
 
 namespace {
 
 // Initial decision of the peripheral content decision.
 // These numeric values are used in UMA logs; do not change them.
 enum PeripheralHeuristicDecision {
   HEURISTIC_DECISION_PERIPHERAL = 0,
   HEURISTIC_DECISION_ESSENTIAL_SAME_ORIGIN = 1,
   HEURISTIC_DECISION_ESSENTIAL_CROSS_ORIGIN_BIG = 2,
   HEURISTIC_DECISION_ESSENTIAL_CROSS_ORIGIN_WHITELISTED = 3,
   HEURISTIC_DECISION_ESSENTIAL_CROSS_ORIGIN_TINY = 4,
   HEURISTIC_DECISION_NUM_ITEMS
 };
 
 const char kPeripheralHeuristicHistogram[] =
     "Plugin.PowerSaver.PeripheralHeuristic";
 
-// Maximum dimensions plugin content may have while still being considered
-// peripheral content. These are similar to the numbers used by WebKit.
-const int kPeripheralContentMaxWidth = 398;
-const int kPeripheralContentMaxHeight = 298;
-
 // Plugin content below this size in height and width is considered "tiny".
 // Tiny content is never peripheral, as tiny plugins often serve a critical
 // purpose, and the user often cannot find and click to unthrottle it.
 const int kPeripheralContentTinySize = 5;
 
 void RecordDecisionMetric(PeripheralHeuristicDecision decision) {
   UMA_HISTOGRAM_ENUMERATION(kPeripheralHeuristicHistogram, decision,
                             HEURISTIC_DECISION_NUM_ITEMS);
 }
 
@@ skipping 118 matching lines @@
   }
 
   // Never mark tiny content as peripheral.
   if (width <= kPeripheralContentTinySize &&
       height <= kPeripheralContentTinySize) {
     RecordDecisionMetric(HEURISTIC_DECISION_ESSENTIAL_CROSS_ORIGIN_TINY);
     return false;
   }
 
   // Plugin content large in both dimensions are the "main attraction".
-  if (width >= kPeripheralContentMaxWidth &&
-      height >= kPeripheralContentMaxHeight) {
+  if (PluginInstanceThrottler::IsLargeContent(width, height)) {
     RecordDecisionMetric(HEURISTIC_DECISION_ESSENTIAL_CROSS_ORIGIN_BIG);
     if (cross_origin_main_content)
       *cross_origin_main_content = true;
     return false;
   }
 
   RecordDecisionMetric(HEURISTIC_DECISION_PERIPHERAL);
   return true;
 }
 
 void PluginPowerSaverHelper::WhitelistContentOrigin(
     const GURL& content_origin) {
   DCHECK_EQ(content_origin.GetOrigin(), content_origin);
   if (origin_whitelist_.insert(content_origin).second) {
     Send(new FrameHostMsg_PluginContentOriginAllowed(
         render_frame()->GetRoutingID(), content_origin));
   }
 }
 
 }  // namespace content