Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2494)

Unified Diff: runtime/observatory/lib/src/elements/heap_profile.dart

Issue 1124153006: Heap snapshot visualizations (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/heap_profile.dart
diff --git a/runtime/observatory/lib/src/elements/heap_profile.dart b/runtime/observatory/lib/src/elements/heap_profile.dart
index 5e097e5e7a0d5606f021059ca333691a3d9b1013..01c3608b660dcabb59329e72e8967e5886964723 100644
--- a/runtime/observatory/lib/src/elements/heap_profile.dart
+++ b/runtime/observatory/lib/src/elements/heap_profile.dart
@@ -26,7 +26,6 @@ class ClassSortedTable extends SortedTable {
}
}
-/// Displays an Error response.
@CustomTag('heap-profile')
class HeapProfileElement extends ObservatoryElement {
@observable String lastServiceGC = '---';
@@ -103,11 +102,11 @@ class HeapProfileElement extends ObservatoryElement {
_subscription.cancel();
super.detached();
}
-
+
// Keep at most one outstanding auto-refresh RPC.
bool refreshAutoPending = false;
bool refreshAutoQueued = false;
-
+
void _onEvent(ServiceEvent event) {
if (autoRefresh && event.eventType == 'GC') {
if (!refreshAutoPending) {
@@ -232,6 +231,9 @@ class HeapProfileElement extends ObservatoryElement {
var cell = tr.children[i];
cell.title = row.values[i].toString();
cell.text = classTable.getFormattedValue(rowIndex, i);
+ if (i > 1) { // Numbers.
+ cell.style.textAlign = 'right';
+ }
}
}

Powered by Google App Engine
This is Rietveld 408576698