Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1124153005: Adding ThreadTaskRunnerHandle in lieu of MessageLoopProxy in net/cert and net/cookies module (Closed)

Created:
5 years, 7 months ago by anujsharma
Modified:
5 years, 7 months ago
Reviewers:
eroman
CC:
chromium-reviews, erikwright (departed), cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding ThreadTaskRunnerHandle in lieu of MessageLoopProxy in net/cert and net/cookies module MessageLoopProxy is deprecated. This basically does a search and replace of: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). MessageLoopProxy -> SingleThreadTaskRunner BUG=391045 Committed: https://crrev.com/afc451774403bb76323d40020dcb48ffd0306461 Cr-Commit-Position: refs/heads/master@{#329998}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M net/cert/nss_cert_database_chromeos_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/cert/nss_cert_database_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/cookies/cookie_monster.cc View 4 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
anujsharma
PTAL
5 years, 7 months ago (2015-05-13 10:05:15 UTC) #2
eroman
lgtm
5 years, 7 months ago (2015-05-14 23:29:43 UTC) #3
anujsharma
On 2015/05/14 23:29:43, eroman (sick slow) wrote: > lgtm Thanks eroman for lgtm.
5 years, 7 months ago (2015-05-14 23:56:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124153005/1
5 years, 7 months ago (2015-05-14 23:58:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 00:50:43 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 00:51:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/afc451774403bb76323d40020dcb48ffd0306461
Cr-Commit-Position: refs/heads/master@{#329998}

Powered by Google App Engine
This is Rietveld 408576698