Source/core/fetch/Resource.h - Issue 1124153003: [Oilpan] [Reland] Migrate classes under core/fetch to Oilpan heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/fetch/Resource.h

Issue 1124153003: [Oilpan] [Reland] Migrate classes under core/fetch to Oilpan heap (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Work for comment Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/fetch/Resource.h

diff --git a/Source/core/fetch/Resource.h b/Source/core/fetch/Resource.h

index ba8f7f3c7026e42fff0f2fd3583ddd599e3ced10..e5c61ebe8b336b942940cd1146d5452b7193eec9 100644

--- a/Source/core/fetch/Resource.h

+++ b/Source/core/fetch/Resource.h

@@ -340,7 +340,7 @@ protected:

ResourceRequest m_resourceRequest;

AtomicString m_accept;

- RefPtrWillBeMember<ResourceLoader> m_loader;

+ PersistentWillBeMember<ResourceLoader> m_loader;

Nico 2015/08/25 04:23:01 Some tests leak m_loader, for example: http://buil

peria 2015/08/25 07:48:14 I confirmed this Persistent leaked a loader. I'll

ResourceLoaderOptions m_options;

ResourceResponse m_response;

« no previous file with comments | « Source/core/fetch/MemoryCacheTest.cpp ('k') | Source/core/fetch/ResourceFetcher.h » ('j') | no next file with comments »