Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Unified Diff: Source/core/loader/FrameFetchContextTest.cpp

Issue 1124153003: [Oilpan] [Reland] Migrate classes under core/fetch to Oilpan heap (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/loader/FrameFetchContext.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/FrameFetchContextTest.cpp
diff --git a/Source/core/loader/FrameFetchContextTest.cpp b/Source/core/loader/FrameFetchContextTest.cpp
index 9613a23ac79d43e8be5ef8b1db43a34b07a9aa62..8c6a73c67049c28b3e87b3301870d3d9d32c857b 100644
--- a/Source/core/loader/FrameFetchContextTest.cpp
+++ b/Source/core/loader/FrameFetchContextTest.cpp
@@ -59,7 +59,7 @@ protected:
dummyPageHolder->page().setDeviceScaleFactor(1.0);
documentLoader = DocumentLoader::create(&dummyPageHolder->frame(), ResourceRequest("http://www.example.com"), SubstituteData());
document = toHTMLDocument(&dummyPageHolder->document());
- fetchContext = &documentLoader->fetcher()->context();
+ fetchContext = static_cast<FrameFetchContext*>(&documentLoader->fetcher()->context());
FrameFetchContext::provideDocumentToContext(*fetchContext, document.get());
}
@@ -116,7 +116,7 @@ protected:
// as the ResourceFetcher and Document live due to indirect usage.
RefPtrWillBePersistent<DocumentLoader> documentLoader;
RefPtrWillBePersistent<Document> document;
- FetchContext* fetchContext;
+ Persistent<FrameFetchContext> fetchContext;
haraken 2015/07/07 13:02:42 Can we use Persistent<FetchContext>? Then you won'
peria 2015/07/08 02:36:09 Done.
};
TEST_F(FrameFetchContextUpgradeTest, UpgradeInsecureResourceRequests)
@@ -232,7 +232,7 @@ protected:
dummyPageHolder->page().setDeviceScaleFactor(1.0);
documentLoader = DocumentLoader::create(&dummyPageHolder->frame(), ResourceRequest("http://www.example.com"), SubstituteData());
document = toHTMLDocument(&dummyPageHolder->document());
- fetchContext = &documentLoader->fetcher()->context();
+ fetchContext = static_cast<FrameFetchContext*>(&documentLoader->fetcher()->context());
FrameFetchContext::provideDocumentToContext(*fetchContext, document.get());
}
@@ -263,7 +263,7 @@ protected:
// as the ResourceFetcher and Document live due to indirect usage.
RefPtrWillBePersistent<DocumentLoader> documentLoader;
RefPtrWillBePersistent<Document> document;
- FetchContext* fetchContext;
+ Persistent<FrameFetchContext> fetchContext;
};
TEST_F(FrameFetchContextHintsTest, MonitorDPRHints)
« no previous file with comments | « Source/core/loader/FrameFetchContext.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698