Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1124133004: Add PolymerElements/paper-item and run reproduce.sh (Closed)

Created:
5 years, 7 months ago by michaelpg
Modified:
5 years, 7 months ago
Reviewers:
Jeremy Klein
CC:
chromium-reviews, michaelpg+watch-polymer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add paper-item#^0.8.0 and run reproduce.sh This brings paper-item v0.8.2 into third_party/polymer/v0_8. I got a presubmit warning about not updating README.chromium. Will that actually be a problem in the CQ? BUG=485381 Committed: https://crrev.com/dbcc99dfe30cd56a36a231db576d7d7ea6c6622e Cr-Commit-Position: refs/heads/master@{#329464}

Patch Set 1 #

Patch Set 2 : re-run to grab paper-menu#0.8.3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+544 lines, -565 lines) Patch
M third_party/polymer/v0_8/bower.json View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/polymer/v0_8/components-chromium/iron-meta/.bower.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/polymer/v0_8/components-chromium/iron-selector/.bower.json View 1 chunk +3 lines, -3 lines 0 comments Download
A third_party/polymer/v0_8/components-chromium/paper-item/README.md View 1 chunk +2 lines, -0 lines 0 comments Download
A + third_party/polymer/v0_8/components-chromium/paper-item/bower.json View 1 chunk +12 lines, -9 lines 0 comments Download
A + third_party/polymer/v0_8/components-chromium/paper-item/index.html View 3 chunks +6 lines, -3 lines 0 comments Download
A third_party/polymer/v0_8/components-chromium/paper-item/paper-icon-item.html View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components-chromium/paper-item/paper-icon-item-extracted.js View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components-chromium/paper-item/paper-item.html View 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components-chromium/paper-item/paper-item-body.html View 1 chunk +57 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components-chromium/paper-item/paper-item-body-extracted.js View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components-chromium/paper-item/paper-item-extracted.js View 1 chunk +18 lines, -0 lines 0 comments Download
A + third_party/polymer/v0_8/components-chromium/paper-item/paper-item-shared.css View 1 chunk +13 lines, -4 lines 0 comments Download
M third_party/polymer/v0_8/components-chromium/paper-menu/.bower.json View 1 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/polymer/v0_8/components-chromium/paper-menu/bower.json View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v0_8/components-chromium/paper-menu/paper-menu.html View 1 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/polymer/v0_8/components-chromium/paper-menu/paper-menu-extracted.js View 1 1 chunk +3 lines, -247 lines 0 comments Download
M third_party/polymer/v0_8/components/iron-meta/.bower.json View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/polymer/v0_8/components/iron-selector/.bower.json View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/polymer/v0_8/components/paper-item/.bower.json View 1 chunk +13 lines, -11 lines 0 comments Download
A third_party/polymer/v0_8/components/paper-item/README.md View 1 chunk +2 lines, -0 lines 0 comments Download
A + third_party/polymer/v0_8/components/paper-item/bower.json View 1 chunk +12 lines, -9 lines 0 comments Download
A + third_party/polymer/v0_8/components/paper-item/index.html View 3 chunks +6 lines, -3 lines 0 comments Download
A third_party/polymer/v0_8/components/paper-item/paper-icon-item.html View 1 chunk +84 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components/paper-item/paper-item.html View 1 chunk +60 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components/paper-item/paper-item-body.html View 1 chunk +73 lines, -0 lines 0 comments Download
A + third_party/polymer/v0_8/components/paper-item/paper-item-shared.css View 1 chunk +13 lines, -4 lines 0 comments Download
M third_party/polymer/v0_8/components/paper-menu/.bower.json View 1 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/polymer/v0_8/components/paper-menu/bower.json View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v0_8/components/paper-menu/paper-menu.html View 1 4 chunks +6 lines, -249 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
michaelpg
5 years, 7 months ago (2015-05-12 08:41:06 UTC) #2
Jeremy Klein
lgtm The presubmit warning shouldn't be a problem.
5 years, 7 months ago (2015-05-12 18:24:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124133004/20001
5 years, 7 months ago (2015-05-12 19:35:56 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-12 19:51:29 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 19:52:23 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dbcc99dfe30cd56a36a231db576d7d7ea6c6622e
Cr-Commit-Position: refs/heads/master@{#329464}

Powered by Google App Engine
This is Rietveld 408576698