Issue 1124133002: Rename findSetLayoutObjects() to mapDescendantToColumnSet()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1124133002: Rename findSetLayoutObjects() to mapDescendantToColumnSet() (Closed)

Created:
5 years, 7 months ago by mstensho (USE GERRIT)

Modified:
5 years, 7 months ago

Reviewers:
dsinclair

CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/remotes/origin/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Rename findSetLayoutObjects() to mapDescendantToColumnSet() It got renamed from findSetRendering() to findSetLayoutObjects() during the render -> layout rename. findSetLayoutObjects() isn't a meaningful name. Then again, findSetRendering() wasn't a great name either (it meant "find the column set that renders (paints, hit-tests, etc.) the specified layoutObject", but that probably wasn't too clear). So let's try with mapDescendantToColumnSet(), which more accurately describes what the method does. R=dsinclair@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194974

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -23 lines)			Patch
M	Source/core/layout/LayoutMultiColumnFlowThread.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/layout/LayoutMultiColumnFlowThread.cpp	View	4 chunks	+8 lines, -7 lines	0 comments	Download
M	Source/core/layout/LayoutMultiColumnFlowThreadTest.cpp	View	11 chunks	+14 lines, -14 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124133002/1

5 years, 7 months ago (2015-05-06 13:28:57 UTC) #4

commit-bot: I haz the power

5 years, 7 months ago (2015-05-06 13:32:45 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194974

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages